Remove 'Async' from short/long path requests names
Having Async in the name was not really informative and made it awkward to reuse for non-async code.
Reviewed By: Kuba386
Differential Revision: https://code.wildfiregames.com/D1854
Remove 'Async' from short/long path requests names
Description
Details
Event TimelineComment Actions
Would have been good if there was mentioned which aspects were reviewed, what was tested.
It was informative, because it informed the reader that those requests are handled asynchroneously.
'Awkward' is subjective and not informative either. I guess one can agree to the diff if there aren't any sync requests that I didn't stumble upon. Comment Actions The struct's name should reflect its content, not how it is handled. The contents of these structs are path requests (with an optional ticket number which is only useful when async). I guess we can debate if m_ShortPathRequest and m_LongPathRequest should have kept the async in their name, but I don't think it's very useful. |