HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22323

Further cleanup of MikkTSpace
rP22323
Actions

Description

Further cleanup of MikkTSpace

  • Move the * and & to the correct side,
  • Add .0 and 0.f to clearly mark the types
  • Pass pointers instead of arrays
  • Add a newline after forward declaration
  • Add spaces between operators
  • Use c++ cast

Reviewed by: @vladislavbelov

Differential Revision: https://code.wildfiregames.com/D1934

Details

Committed
StanMay 31 2019, 1:03 AM
Reviewer
vladislavbelov
Differential Revision
D1934: Further cleanup for MikkTspace.
Parents
rP22322: Seperate stable from barracks
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7689
Build 12530: Post-Commit BuildJenkins

Event Timeline

Stan committed rP22323: Further cleanup of MikkTSpace.May 31 2019, 1:03 AM
Stan added a subscriber: vladislavbelov.
Harbormaster completed building B7689: rP22323: Further cleanup of MikkTSpace.May 31 2019, 1:34 AM
elexis added a subscriber: elexis.Jun 25 2019, 5:46 AM

Pass pointers instead of arrays

How are arrays passed?

Stan added a comment.Jun 25 2019, 8:49 AM
In rP22323#34353, @elexis wrote:

Pass pointers instead of arrays

How are arrays passed?

By reference, I meant passing a *type instead of type[]

Changes (3)

PathSize
ps/
trunk/
source/
renderer/

rP22323

View Options

ps/trunk/source/renderer/MikktspaceWrap.cpp

Loading...
View Options

ps/trunk/source/renderer/MikktspaceWrap.h

Loading...
View Options

ps/trunk/source/renderer/ModelRenderer.cpp

Loading...
Wildfire Games ยท Phabricator