HomeWildfire Games

Improve UTF-8 character handling in Atlas

Tags
None
Subscribers
Tokens
"Love" token, awarded by Itms."Like" token, awarded by elexis.

Description

Improve UTF-8 character handling in Atlas

(Also prevents the compile-time warnings reported in the abandoned D1432)

Accepted by: Itms
Patch linting by: Stan, Vladislav, wraitii
Also tested by: Imarok
Fixes: #4936
Differential Revision: https://code.wildfiregames.com/D1395

Event Timeline

Itms awarded a token.Jun 4 2019, 11:12 AM
elexis raised a concern with this commit.Fri, Jul 5, 6:21 PM
elexis added a subscriber: elexis.
elexis added inline comments.
/ps/trunk/source/tools/atlas/GameInterface/ActorViewer.h
38

Compiling without precompiled headers:

../../../source/tools/atlas/GameInterface/ActorViewer.h:38:39: error: ‘CStr’ does not name a type
  38 |  void SetActor(const CStrW& id, const CStr& animation, player_id_t playerID);

Forward declaration of CStr8 fixes

This commit now has outstanding concerns.Fri, Jul 5, 6:21 PM
elexis removed an auditor: elexis.Sun, Jul 7, 11:55 PM
This commit no longer requires audit.Sun, Jul 7, 11:55 PM
Stan added a subscriber: Stan.Thu, Jul 18, 2:46 PM
Stan added inline comments.
/ps/trunk/source/tools/atlas/AtlasUI/ActorEditor/ActorEditor.cpp
175

MSVC2015: warning C4130: '==': logical operation on address of string constant

Maybe use http://www.cplusplus.com/reference/string/string/compare/

or

/http://www.cplusplus.com/reference/cstring/strcmp

178

Same here.