HomeWildfire Games

Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs…
Concern RaisedrP22348

Description

Delete old redistributables for VS 2010, and add new ones for VS 2015. Refs #5379.

Details

Auditors
Stan
historic_bruno
Committed
ItmsJun 8 2019, 9:45 AM
Parents
rP22347: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7836
Build 12744: Post-Commit Build (Data only)Jenkins

Event Timeline

Stan raised a concern with this commit.Jun 18 2019, 12:29 AM
Stan added a subscriber: Stan.

broke debug build. instant segfault

This commit now has outstanding concerns.Jun 18 2019, 12:29 AM
elexis added a subscriber: elexis.Jun 25 2019, 5:42 PM

Tried clean build? Got a stacktrace?

Itms requested verification of this commit.Jun 28 2019, 12:40 AM

Vorbis was compiled with VS2010 and still depended on the redistributables I deleted. I upgraded and recompiled libogg and libvorbis in rP22406, which fixes the issue for me. Other libs might create the same issue if built with VS2010 still.

This commit now requires verification by auditors.Jun 28 2019, 12:40 AM
Stan accepted this commit.Jun 29 2019, 5:13 PM

Now fixed :)

All concerns with this commit have now been addressed.Jun 29 2019, 5:13 PM
historic_bruno raised a concern with this commit.Jul 23 2019, 2:55 AM
historic_bruno added a subscriber: historic_bruno.

nvtt.dll still depends on msvcr100.dll, which causes an error on some systems (particularly, clean installs of XP SP3). Should be rebuilt with VS2015 (vc140_xp toolset)

This commit now has outstanding concerns.Jul 23 2019, 2:55 AM

Also nspr4.dll depends on msvcr100.dll