HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22370

Refactors Developer Overlay using an object instead of global functions.
AuditedrP22370
Actions

Description

Refactors Developer Overlay using an object instead of global functions.

Reviewed By: wraitii
Commented By: elexis
Differential Revision: https://code.wildfiregames.com/D1928

Details

Auditors
elexis
Committed
vladislavbelovJun 12 2019, 9:21 PM
Reviewer
wraitii
Differential Revision
D1928: Refactors Developer Overlay
Parents
rP22369: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7912
Build 12876: Post-Commit BuildJenkins

Event Timeline

vladislavbelov committed rP22370: Refactors Developer Overlay using an object instead of global functions..Jun 12 2019, 9:21 PM
Harbormaster completed building B7912: rP22370: Refactors Developer Overlay using an object instead of global functions..Jun 12 2019, 9:55 PM
elexis raised a concern with this commit.Jul 9 2019, 6:25 PM
elexis added a subscriber: elexis.

From https://wildfiregames.com/forum/index.php?/topic/26471-error-javascript-error-guisessioninputjs-line-799-referenceerror-g_developeroverlay-is-not-defined/

	ERROR: JavaScript error: gui/session/input.js line 799
ReferenceError: g_DeveloperOverlay is not defined
  handleInputAfterGui@gui/session/input.js:799:6
ERROR: JavaScript error: gui/session/input.js line 799
ReferenceError: g_DeveloperOverlay is not defined
  handleInputAfterGui@gui/session/input.js:799:6
ERROR: JavaScript error: gui/session/selection.js line 218
ReferenceError: g_DeveloperOverlay is not defined
  EntitySelection.prototype.update@gui/session/selection.js:218:44
  updateGUIObjects@gui/session/session.js:930:2
  onSimulationUpdate@gui/session/session.js:875:2
  __eventhandler110 (simulationupdate)@session simulationupdate:0:1
ERROR: JavaScript error: gui/session/selection.js line 218
ReferenceError: g_DeveloperOverlay is not defined
  EntitySelection.prototype.update@gui/session/selection.js:218:44
  updateGUIObjects@gui/session/session.js:930:2
  onSimulationUpdate@gui/session/session.js:875:2
  __eventhandler110 (simulationupdate)@session simulationupdate:0:1
ERROR: JavaScript error: gui/session/selection.js line 218
ReferenceError: g_DeveloperOverlay is not defined
  EntitySelection.prototype.update@gui/session/selection.js:218:44
  updateGUIObjects@gui/session/session.js:930:2
  onSimulationUpdate@gui/session/session.js:875:2
  __eventhandler110 (simulationupdate)@session simulationupdate:0:1
This commit now has outstanding concerns.Jul 9 2019, 6:25 PM
elexis accepted this commit.Jul 10 2019, 1:22 AM

False alert, the user used a mod.

All concerns with this commit have now been addressed.Jul 10 2019, 1:22 AM
elexis mentioned this in D2383: Rewrite DeveloperOverlay and TimeWarp to use class syntax and split classes.Oct 19 2019, 1:33 AM
elexis mentioned this in rP23081: Rewrite developer overlay to use class syntax, one class per checkbox, a class….Oct 19 2019, 2:27 AM

Changes (7)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/

rP22370

View Options

ps/trunk/binaries/data/mods/public/gui/session/developer_overlay.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/developer_overlay.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/input.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/menu.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/selection.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

Loading...
Wildfire Games · Phabricator