HomeWildfire Games

Wrap damage types in a Damage element in XML templates to prepare for…

Description

Wrap damage types in a Damage element in XML templates to prepare for genericizing them.

Patch By: Freagarach
Reviewed By: Wraitii

Differential Revision: https://code.wildfiregames.com/D1950

Details

Committed
wraitiiJun 16 2019, 7:08 PM
Reviewer
wraitii
Differential Revision
D1950: Create "Damage"-container for damage types in templates.
Parents
rP22378: Fix cppformat failures on MacOS tests.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7975
Build 12980: Post-Commit BuildJenkins

Event Timeline

Nescio added a subscriber: Nescio.Jun 16 2019, 8:58 PM

"genericizing" [sic], a neologism? English already has "generalize".

"genericizing" [sic], a neologism? English already has "generalize".

It appears to be a word: https://en.wiktionary.org/wiki/genericizing
genericize = make generic. Which is better than "make general" here.

Stan added a subscriber: Stan.Jun 17 2019, 8:14 AM
Stan added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Attack.js
178

@wraitii How does that even work (Missing capital)

Freagarach added a subscriber: Freagarach.EditedMon, Jun 17, 5:49 PM

We *did* forget something: the examples in "Attack.js". New diff for that? Or update with D1938?

Stan added a comment.Mon, Jun 17, 5:58 PM

Yeah new diff. Not good combining fixes with other stuff.

In rP22379#34021, @Stan wrote:

Yeah new diff. Not good combining fixes with other stuff.

Thought so as well, I'll make the diff when I upload the new D1938 ;)

Freagarach added inline comments.Mon, Jun 17, 8:56 PM
/ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Attack.js
178

The "GetSplashDamage" returns "damage" in lowercase (just like "friendlyFire" and "shape").