Define variables before mentioning them in scripted component tests, and add a linter rule for this.
Patch By: Krinkle
Differential Revision: https://code.wildfiregames.com/D1986
Description
Description
Details
Details
- Auditors
elexis - Committed
Itms Jun 16 2019, 10:48 PM - Differential Revision
- D1986: simulation tests: eslint fixes for no-use-before-define
- Parents
- rP22379: Wrap damage types in a Damage element in XML templates to prepare for…
- Branches
- Unknown
- Tags
- Build Status
Buildable 7985 Build 12996: Post-Commit Build Jenkins
Event Timeline
| /ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Foundation.js | ||
|---|---|---|
| 47 | (only pos variable was necessary, but keeping them grouped is okay) | |
| /ps/trunk/build/jenkins/lint-config/eslintrc.json | ||
| 22 | Agree that it is a benefitial pattern to define variables before referencing to them, that's one of the major purposes of the let keyword over var. refs https://eslint.org/docs/rules/no-use-before-define | |