HomeWildfire Games

3 New temperate maps by BigTiger.
AuditedrP22386

Description

3 New temperate maps by BigTiger.

Details

Auditors
elexis
Committed
StanJun 17 2019, 8:24 PM
Parents
rP22385: New particle actors by BigTiger.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7996
Build 13011: Post-Commit Build (macOS)Jenkins

Event Timeline

elexis raised a concern with this commit.Jun 25 2019, 4:18 AM
elexis added a subscriber: elexis.

Only a small concern, but something that should be fixed for the release. The maps should have the "new" keyword, so that they appear in the "new maps" filter.

/ps/trunk/binaries/data/mods/public/maps/skirmishes/Farmland (2).xml
45

new keyword

This commit now has outstanding concerns.Jun 25 2019, 4:18 AM
Stan added a comment.Jun 25 2019, 8:50 AM

Yeah I was waiting for something like D2009 which I would have done myself if someone hadn't come to the rescue. Will add the keyword soon.

Stan requested verification of this commit.Jun 25 2019, 11:08 PM
This commit now requires verification by auditors.Jun 25 2019, 11:08 PM
elexis accepted this commit.Jun 25 2019, 11:16 PM

Tested the maps, they are very good!
Thanks for the fix.

All concerns with this commit have now been addressed.Jun 25 2019, 11:16 PM

Civs should not be specified by the map.

Except for Egypt (3v3) that has prebuilt cities for specific civs, these are the only 3 skirmish maps that specifiy player civs.
The player owned entities are actually Skirmish replacement entities, so the one can play it with different civs and not get an entity that isnt part of that civ when starting the match (contrary to Egypt, which might perhaps be more a scenario than a skirmish map).
There are only traditional 4 starting men, 4 starting women, 1 cav and 1 CC, so there is no reason why the civ should be preselected or predetermined.