Diffusion 0 A.D. Public Repository rP22428

Return Gathering to A23 behaviour - Make units try to gather near the target…
rP22428
Actions

Tags

None

Subscribers

None

Description

Return Gathering to A23 behaviour - Make units try to gather near the target resource's position instead of their position.

Units were incorrectly looking at resources near their position following rP22342.

Fixes #5477.

Differential Revision: https://code.wildfiregames.com/D2034

Details

Committed

Jul 3 2019, 7:57 PM

Differential Revision

D2034: Return Gathering to A23 behaviour

Parents

rP22427: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8179
Build 13324: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22428: Return Gathering to A23 behaviour - Make units try to gather near the target….Jul 3 2019, 7:57 PM

Harbormaster completed building B8179: rP22428: Return Gathering to A23 behaviour - Make units try to gather near the target….Jul 3 2019, 8:32 PM

wraitii added inline comments.Jul 4 2019, 9:11 AM

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
2287	Needs a check for undefined herdPos or fixing why that sometimes is undefined. I thought it would always be defined, but it appears there are cases where it's not despite setting it in Gather and in Order.Gather - probably related to pushing new Gather orders or something.

wraitii mentioned this in D2039: Improvements to gather order when out or resources and fix rP22428.Jul 4 2019, 8:57 PM

wraitii mentioned this in rP22434: Improvements to gather order when out or resources and fix rP22428.Jul 4 2019, 9:56 PM

wraitii added inline comments.Jul 14 2019, 10:08 AM

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
532	This erased the initPos too eagerly and should only be called if there is no initPos.

wraitii mentioned this in rP22471: Make sure hunting units don't forget about the initial herd position (fix for….Jul 14 2019, 11:39 AM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

rP22428

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...