Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP22528

Provide ScriptInterface CreateObject and CreateArray functions to replace Eval…
rP22528
Actions

Tags

None

Subscribers

Description

Provide ScriptInterface CreateObject and CreateArray functions to replace Eval calls following rP7259, rP7653 and later.

Differential Revision: https://code.wildfiregames.com/D2080
Previous version reviewed By: Krinkle
Comments By: historic_bruno, wraitii

Details

Committed

Jul 22 2019, 9:35 PM

Differential Revision

D2080: Replace Eval calls with new ScriptInterface CreateObject and CreateArray functions

Parents

rP22527: Easier introduction of new damage types.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8540
Build 13973: Trigger Windows Autobuild
Build 13972: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22528: Provide ScriptInterface CreateObject and CreateArray functions to replace Eval….Jul 22 2019, 9:35 PM

Harbormaster completed building B8540: rP22528: Provide ScriptInterface CreateObject and CreateArray functions to replace Eval….Jul 22 2019, 10:05 PM

elexis mentioned this in D2127: ScriptInterface CreateObject performance improvement.Jul 26 2019, 2:13 PM

elexis mentioned this in D2128: Use CreateObject in EngineScriptConversions.Jul 26 2019, 2:16 PM

vladislavbelov added a subscriber: vladislavbelov.Jul 29 2019, 1:48 PM

vladislavbelov added inline comments.

/ps/trunk/source/lobby/XmppClient.cpp
535	It'd be better to call it `index` or similar. The same for others.
/ps/trunk/source/scriptinterface/ScriptInterface.h
144	One may want to replace these two functions by one with an additional template parameter like `, CharType,` and add a type check.

elexis added inline comments.Jul 29 2019, 1:51 PM

/ps/trunk/source/scriptinterface/ScriptInterface.h
144	Same for SetProperty. But I'm mostly worried about performance. The JSAutoRequest is created for every property instead of only once, so I propose here to do it only once: D2127.

elexis mentioned this in rP22680: Improve performance of ScriptInterface::CreateObject from rP22528 / D2080 by….Aug 17 2019, 5:30 AM

elexis mentioned this in D1751: [WIP] Map flares.Aug 31 2019, 12:54 PM

elexis mentioned this in rP22867: Implement NetClient PushGuiMessage using parameter pack and ScriptInterface….Sep 7 2019, 6:52 PM

Changes (23)

Path

Size

ps/

trunk/

source/

graphics/

MapGenerator.cpp

gui/

scripting/

JSInterface_IGUIObject.cpp

lobby/

network/

NetClientTurnManager.cpp

ps/

GameSetup/

ProfileViewer.cpp

VisualReplay.cpp

scripting/

JSInterface_ModIo.cpp

JSInterface_VFS.cpp

scriptinterface/

ScriptInterface.cpp

ScriptInterface.h

simulation2/

Simulation2.cpp

components/

CCmpAIManager.cpp

ICmpAIManager.cpp

tools/

atlas/

GameInterface/

Handlers/

MapHandlers.cpp

rP22528

ps/trunk/source/graphics/MapGenerator.cpp

Loading...

ps/trunk/source/graphics/MapReader.cpp

Loading...

ps/trunk/source/gui/IGUIObject.cpp

Loading...

ps/trunk/source/gui/MiniMap.cpp

Loading...

ps/trunk/source/gui/scripting/JSInterface_IGUIObject.cpp

Loading...

ps/trunk/source/lobby/XmppClient.cpp

Loading...

ps/trunk/source/network/NetClient.cpp

Loading...

ps/trunk/source/network/NetClientTurnManager.cpp

Loading...

ps/trunk/source/network/StunClient.cpp

Loading...

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...

ps/trunk/source/ps/GameSetup/HWDetect.cpp

Loading...

ps/trunk/source/ps/Mod.cpp

Loading...

ps/trunk/source/ps/ProfileViewer.cpp

Loading...

ps/trunk/source/ps/SavedGame.cpp

Loading...

ps/trunk/source/ps/VisualReplay.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_ModIo.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_VFS.cpp

Loading...

ps/trunk/source/scriptinterface/ScriptInterface.cpp

Loading...

ps/trunk/source/scriptinterface/ScriptInterface.h

Loading...

ps/trunk/source/simulation2/Simulation2.cpp

Loading...

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

Loading...

ps/trunk/source/simulation2/components/ICmpAIManager.cpp

Loading...

ps/trunk/source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp

Loading...