HomeWildfire Games

Introduce CGUIColor type inheriting Color type and switch the GUI to…

Description

Introduce CGUIColor type inheriting Color type and switch the GUI to exclusively use that.

The type differs from the Color type, because contrary to Color, it can be created from a color predefined in the GUI page (such as "yellow").
Move this predefined color check to the new class instead of hardcoding it in FromJSVal / ToJSVal, GUIUtil, JSInterface_IGUIObject and to straighten the latter.

Delete fov_wedge_color from Minimap, unused since introduction in rP1230.

Event Timeline

wraitii raised a concern with this commit.Jul 27 2019, 4:23 PM
wraitii added a subscriber: wraitii.
wraitii added inline comments.
/ps/trunk/source/gui/scripting/GuiScriptConversions.cpp
163

This doesn't compile on clang, needs c_Str().

This commit now has outstanding concerns.Jul 27 2019, 4:23 PM
elexis requested verification of this commit.Jul 27 2019, 5:35 PM
This commit now requires verification by auditors.Jul 27 2019, 5:35 PM
elexis removed an auditor: wraitii.Jul 27 2019, 5:35 PM
This commit no longer requires audit.Jul 27 2019, 5:35 PM
wraitii accepted this commit.Jul 27 2019, 5:37 PM
All concerns with this commit have now been addressed.Jul 27 2019, 5:37 PM
wraitii resigned from this commit.Jul 27 2019, 5:41 PM
This commit no longer requires audit.Jul 27 2019, 5:41 PM