Add missing CPos FromJSVal, ToJSVal following rP1540.
Description
Description
Details
Details
- Committed
elexis Jul 29 2019, 1:56 PM - Parents
- rP22572: [i18n] Updated POT and PO files.
- Branches
- Unknown
- Tags
- Build Status
Buildable 8652 Build 14177: Trigger Windows Autobuild Build 14176: Post-Commit Build Jenkins
Event Timeline
Comment Actions
Can be tested by adding this in session.js init:
Engine.GetGUIObjectByName("placementTooltip").offset = new Vector2D(200, 0);
| /ps/trunk/source/scriptinterface/ScriptConversions.cpp | ||
|---|---|---|
| 350 | Useless and looks strange. | |
| /ps/trunk/source/scriptinterface/ScriptConversions.cpp | ||
|---|---|---|
| 350 | The reader assuming that every line is written because it has an effect on the codeflow is misled to believe that this line has one, indeed. | |
| /ps/trunk/source/scriptinterface/ScriptConversions.cpp | ||
|---|---|---|
| 350 | #undef inplace is ok. Implementation defines won't leak to any other file. For headers defines you need too many undef. For ex. LOGWARNING. I insist to remove/not add undef for non-inplace defines (except special places in headers). | |