HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22574

Remove both copies of the 15-fold copies of the JSI_IGUIObject::getProperty and…
rP22574
Actions

Description

Remove both copies of the 15-fold copies of the JSI_IGUIObject::getProperty and setProperty setting case handlers following the FromJSVal / ToJSVal template specializations implemented in

The removed JS_ReportError calls were redundant.

Details

Committed
elexisJul 29 2019, 4:46 PM
Differential Revision
D1699: Remove obsolete JSI_GUIMouse, JSI_IGUIObject::construct, JS_THIS_OBJECT and cleanup JS GUI interface
Parents
rP22573: Add missing CPos FromJSVal, ToJSVal following rP1540.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8653
Build 14179: Trigger Windows Autobuild
Build 14178: Post-Commit BuildJenkins

Event Timeline

elexis committed rP22574: Remove both copies of the 15-fold copies of the JSI_IGUIObject::getProperty and….Jul 29 2019, 4:46 PM
Harbormaster completed building B8653: rP22574: Remove both copies of the 15-fold copies of the JSI_IGUIObject::getProperty and….Jul 29 2019, 4:55 PM
wraitii added a subscriber: wraitii.Jul 29 2019, 5:16 PM
wraitii added inline comments.
/ps/trunk/source/gui/IGUIObject.cpp
35

I think you're accidentally copying Name here.

44

Same here.

elexis added inline comments.Jul 29 2019, 5:24 PM
/ps/trunk/source/gui/IGUIObject.cpp
35

Nope.

wraitii added inline comments.Jul 29 2019, 5:30 PM
/ps/trunk/source/gui/IGUIObject.cpp
35

seen on IRC -> On purpose to avoid possible dangling references.

elexis added inline comments.Jul 29 2019, 5:34 PM
/ps/trunk/source/gui/IGUIObject.cpp
35

Not only possible but certain, and in 100% of the calls and crashing the game instantly on start.

elexis added inline comments.Jul 30 2019, 5:55 PM
/ps/trunk/source/gui/IGUIObject.cpp
44

This one is unused actually. The class is going to be refactored next, then the lambdas are regular functions as well.

elexis mentioned this in D2145: Make IGUIObject settings a template class.Aug 4 2019, 3:33 AM
elexis mentioned this in rP22604: Implement IGUIObject settings as a template class and IGUIObject::AddSetting as….Aug 4 2019, 4:20 AM
elexis mentioned this in D1699: Remove obsolete JSI_GUIMouse, JSI_IGUIObject::construct, JS_THIS_OBJECT and cleanup JS GUI interface.Aug 20 2019, 8:56 PM
elexis added an edge: D1699: Remove obsolete JSI_GUIMouse, JSI_IGUIObject::construct, JS_THIS_OBJECT and cleanup JS GUI interface.

Changes (3)

PathSize
ps/
trunk/
source/
gui/
scripting/

rP22574

View Options

ps/trunk/source/gui/IGUIObject.cpp

Loading...
View Options

ps/trunk/source/gui/IGUIObject.h

Loading...
View Options

ps/trunk/source/gui/scripting/JSInterface_IGUIObject.cpp

Loading...
Wildfire Games · Phabricator