HomeWildfire Games

Refactor renderer options.

Description

Refactor renderer options.

This moves the renderer options into their own class to:@

  • allow one to only include the rendering options, not the whole renderer header, when one wants access to rendering options.
  • centralise rendering changes and their side-effects.
  • clean up code.

Tested by: historic_bruno, Freagarach

Commented by: historic_bruno

Differential Revision: https://code.wildfiregames.com/D1929

Event Timeline

elexis added a subscriber: elexis.Aug 4 2019, 2:42 PM

Build without precompiled headers:

../../../source/renderer/RenderingOptions.cpp:36:2: error: ‘LOGWARNING’ was not declared in this scope

36 |  LOGWARNING("Unknown render path %s", name.c_str());
   |  ^~~~~~~~~~

-> include CLogger.h

elexis raised a concern with this commit.Aug 4 2019, 9:06 PM

(As it doesn't compile currently without pch)

This commit now has outstanding concerns.Aug 4 2019, 9:06 PM
elexis removed an auditor: elexis.Aug 4 2019, 10:12 PM

Thanks for the fix

This commit no longer requires audit.Aug 4 2019, 10:12 PM