HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22615

redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb…
AuditedrP22615
Actions

Description

redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui
Move two duplicated lines from rP21071 in a function

fixes rP21036
Reviewed By: elexis
Comments By: Stan, vladislav
Differential Revision: https://code.wildfiregames.com/D1939

Details

Auditors
FeXoR
Committed
bbAug 5 2019, 4:12 PM
Reviewer
elexis
Differential Revision
D1939: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb some duplication in the gui
Parents
rP22614: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8738
Build 14318: Trigger Windows Autobuild
Build 14317: Post-Commit BuildJenkins

Event Timeline

bb committed rP22615: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb….Aug 5 2019, 4:12 PM
Harbormaster completed building B8738: rP22615: redo rP21036, Create a ConfigDB_CreateAndWriteValueToFile function to absorb….Aug 5 2019, 4:21 PM
FeXoR raised a concern with this commit.Aug 8 2019, 11:22 AM
FeXoR added a subscriber: FeXoR.

This seems to introduce #5554 so I raised a concern.

This commit now has outstanding concerns.Aug 8 2019, 11:22 AM
FeXoR accepted this commit.Aug 9 2019, 1:31 PM
All concerns with this commit have now been addressed.Aug 9 2019, 1:31 PM

Changes (15)

PathSize
ps/
trunk/
binaries/
data/
mods/
mod/
gui/
common/
public/
gui/
common/
gamesetup/
gamesetup_mp/
lobby/
prelobby/
common/
credentials/
session/
top_panel/
splashscreen/
source/
ps/
scripting/

rP22615

View Options

ps/trunk/binaries/data/mods/mod/gui/common/terms.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/common/functions_utility.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup_mp/gamesetup_mp.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/prelobby/common/credentials/credentials.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/menu.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/resource_population.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/top_panel/resources.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/splashscreen/splashscreen.xml

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.cpp

Loading...
View Options

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.h

Loading...
Wildfire Games · Phabricator