HomeWildfire Games

Wind speed computation rework.

Description

Wind speed computation rework.

This reworks wind-speed computation to not use a blurred-heightmap approach but rather a slightly more wind simulation approach. It fixes issues near the edges of some maps.

Differential Revision: https://code.wildfiregames.com/D1721

Event Timeline

elexis raised a concern with this commit.EditedAug 15 2019, 4:58 PM
elexis added a subscriber: elexis.

Shown by gcc 9:

../../../source/renderer/WaterManager.cpp: In member function ‘void WaterManager::RecomputeWindStrength()’:
../../../source/renderer/WaterManager.cpp:1131:17: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
 1131 |     if (point.X < 0 || point.X >= m_MapSize || point.Y < 0 || point.Y >= m_MapSize)
      |         ~~~~~~~~^~~
../../../source/renderer/WaterManager.cpp:1131:56: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
 1131 |     if (point.X < 0 || point.X >= m_MapSize || point.Y < 0 || point.Y >= m_MapSize)
      |                                                ~~~~~~~~^~~
This commit now has outstanding concerns.Aug 15 2019, 4:58 PM
elexis removed an auditor: elexis.Aug 15 2019, 7:04 PM

Thanks for the quick fix!

This commit no longer requires audit.Aug 15 2019, 7:04 PM