Diffusion 0 A.D. Public Repository rP22682

Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a…
rP22682
Actions

Tags

None

Subscribers

None

Tokens

"Love" token, awarded by Silier.

Description

Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a benchmark, refs rP1525.

Differential Revision: https://code.wildfiregames.com/D2184
Refs rP22637/D2163
Tested on: gcc 9, Jenkins

Details

Committed

Aug 17 2019, 1:52 PM

Differential Revision

D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete

Parents

rP22681: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8895
Build 14599: Trigger Windows Autobuild
Build 14598: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22682: Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a….Aug 17 2019, 1:52 PM

elexis added an edge: D2184: Use shared_ptr for SGUIImageEffects to avoid both copy and delete.

Harbormaster completed building B8895: rP22682: Use shared_ptr to avoid copying and deleting SGUIImageEffects, 2.5x faster in a….Aug 17 2019, 2:02 PM

Silier awarded a token.Aug 17 2019, 3:59 PM

elexis mentioned this in D2203: Remove unused argument following rP22695 and cleanup two stray includes.Aug 20 2019, 12:38 PM

elexis mentioned this in rP22720: Erase unused variable following rP22695, clean two stray includes from rP1507..Aug 20 2019, 12:51 PM

elexis added inline comments.Oct 2 2019, 12:34 PM

/ps/trunk/source/gui/CGUISprite.h
106	Perhaps this should not be a shared_ptr nor a raw pointer but an actual value, so that it has better memory layout. The type only contains 2 colors and 1 bool.

Changes (3)

Path

Size

ps/

trunk/

source/

gui/

GUIRenderer.cpp

rP22682

ps/trunk/source/gui/CGUI.cpp

Loading...

ps/trunk/source/gui/CGUISprite.h

Loading...

ps/trunk/source/gui/GUIRenderer.cpp

Loading...