Diffusion 0 A.D. Public Repository rP22693

Use a new GetSetting returning a reference instead of GetSettingPointer when…
rP22693
Actions

Description

Use a new GetSetting returning a reference instead of GetSettingPointer when the setting is known to exist.

Differential Revision: https://code.wildfiregames.com/D2192

Details

Committed

elexis

Aug 19 2019, 12:32 PM

Differential Revision

D2192: Use GetSetting references instead of GetSettingPointer

Parents

rP22692: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8923
Build 14643: Trigger Windows Autobuild
Build 14642: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22693: Use a new GetSetting returning a reference instead of GetSettingPointer when….Aug 19 2019, 12:32 PM

elexis added an edge: D2192: Use GetSetting references instead of GetSettingPointer.

Harbormaster completed building B8923: rP22693: Use a new GetSetting returning a reference instead of GetSettingPointer when….Aug 19 2019, 12:40 PM

elexis awarded a token.Aug 19 2019, 1:51 PM

elexis rescinded a token.

elexis mentioned this in D2193: Stop copying color every draw call for every GUI object using colors ffs.Aug 19 2019, 2:22 PM

elexis mentioned this in rP22694: Stop copying color every draw call for every GUI object using colors..Aug 19 2019, 2:54 PM

elexis mentioned this in rP1518: Fixed things that use a colour rather than a texture (e.g. the progress bars)..Aug 19 2019, 3:41 PM

elexis mentioned this in rP22761: Remove hardcoded C++ fallback font from rP1074 and according TODO from rP1085….Aug 23 2019, 5:47 AM

elexis mentioned this in rP22756: Introduce IGUIObject::PlaySound to unify 19 copies of the UI sound play….

elexis mentioned this in rP22758: Fix missing actual boolean check in the commit removing the odd way to check….

elexis mentioned this in D2215: Delete copy-assignment GUIUtil GetSetting variant.Aug 23 2019, 5:57 AM

elexis mentioned this in rP22765: Replace copy-assigning GUI<T>::GetSetting from rP31 with the reference….Aug 23 2019, 4:43 PM

elexis mentioned this in D2225: Remove unused antique GUIUtil functions and unused GUI includes.Aug 25 2019, 10:19 AM

elexis mentioned this in rP22779: Remove unused GUIUtil functions, unused GUI includes and some tails in GUIUtil..Aug 25 2019, 10:58 AM

elexis mentioned this in D2313: Store GUI object Setting values in class members instead of the heap and avoid repeated GetSetting calls.Sep 27 2019, 1:16 PM

Changes (16)

Path

Size

ps/

trunk/

source/

gui/

rP22693

View Options

ps/trunk/source/gui/CButton.cpp

View Options

ps/trunk/source/gui/CChart.cpp

View Options

ps/trunk/source/gui/CCheckBox.cpp

View Options

ps/trunk/source/gui/CDropDown.cpp

View Options

ps/trunk/source/gui/CImage.cpp

View Options

ps/trunk/source/gui/CInput.cpp

View Options

ps/trunk/source/gui/CInput.h

View Options

ps/trunk/source/gui/CList.cpp

View Options

ps/trunk/source/gui/COList.cpp

View Options

ps/trunk/source/gui/CProgressBar.cpp

View Options

ps/trunk/source/gui/CSlider.cpp

View Options

ps/trunk/source/gui/CText.cpp

View Options

ps/trunk/source/gui/CTooltip.cpp

View Options

ps/trunk/source/gui/GUIutil.cpp

View Options

ps/trunk/source/gui/GUIutil.h

View Options

ps/trunk/source/gui/IGUIObject.cpp

Use a new GetSetting returning a reference instead of GetSettingPointer when…rP22693Actions

Description

Details

Event Timeline

Changes (16)

rP22693

ps/trunk/source/gui/CButton.cpp

ps/trunk/source/gui/CChart.cpp

ps/trunk/source/gui/CCheckBox.cpp

ps/trunk/source/gui/CDropDown.cpp

ps/trunk/source/gui/CImage.cpp

ps/trunk/source/gui/CInput.cpp

ps/trunk/source/gui/CInput.h

ps/trunk/source/gui/CList.cpp

ps/trunk/source/gui/COList.cpp

ps/trunk/source/gui/CProgressBar.cpp

ps/trunk/source/gui/CSlider.cpp

ps/trunk/source/gui/CText.cpp

ps/trunk/source/gui/CTooltip.cpp

ps/trunk/source/gui/GUIutil.cpp

ps/trunk/source/gui/GUIutil.h

ps/trunk/source/gui/IGUIObject.cpp

Use a new GetSetting returning a reference instead of GetSettingPointer when…
rP22693
Actions