Diffusion 0 A.D. Public Repository rP22695

Remove IsBoolTrue helper function from rP7289.
rP22695
Actions

Description

Remove IsBoolTrue helper function from rP7289.

This property is defined as a boolean for every IGUIObject.
If GUIObjects were empowered to make up their own hidden property, then they should also be empowered to use custom boolean hidden properties that don't trigger ResetStates.

Details

Committed

elexis

Aug 19 2019, 8:36 PM

Parents

rP22694: Stop copying color every draw call for every GUI object using colors.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8926
Build 14649: Trigger Windows Autobuild
Build 14648: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22695: Remove IsBoolTrue helper function from rP7289..Aug 19 2019, 8:36 PM

Harbormaster completed building B8926: rP22695: Remove IsBoolTrue helper function from rP7289..Aug 19 2019, 8:42 PM

elexis mentioned this in D2203: Remove unused argument following rP22695 and cleanup two stray includes.Aug 20 2019, 12:38 PM

elexis mentioned this in rP22720: Erase unused variable following rP22695, clean two stray includes from rP1507..Aug 20 2019, 12:51 PM

The commit broke button hover (in session) and minimap camera dragging (at least on Windows). As far as I see, we shouldn't reset states for visible objects.

This commit now has outstanding concerns.Aug 23 2019, 2:02 AM

elexis mentioned this in rP22758: Fix missing actual boolean check in the commit removing the odd way to check….Aug 23 2019, 2:42 AM

Thanks for the notification and bisect!

This commit now requires verification by auditors.Aug 23 2019, 2:42 AM

elexis removed an auditor: vladislavbelov.Aug 23 2019, 5:48 AM

This commit no longer requires audit.Aug 23 2019, 5:48 AM

refs #5575