HomeWildfire Games

Aspis Remake.

Description

Aspis Remake.

Update of aspis textures and mesh with better geometry and higher resolution textures.

Following the fixes of https://trac.wildfiregames.com/ticket/4460

Thread: https://wildfiregames.com/forum/index.php?/topic/26720-task-aspis-remake/page/2/

Details

Committed
AlexandermbAug 20 2019, 4:22 PM
Parents
rP22722: Greaves
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8964
Build 14697: Post-Commit BuildJenkins

Event Timeline

elexis added a subscriber: elexis.Aug 20 2019, 4:51 PM

Jenkins says:

mismatched tag at line 11, column 6, byte 498 at /usr/lib/x86_64-linux-gnu/perl5/5.24/XML/Parser.pm line 187.

The source/tools/xmlvalidator/validator.py script locates:

Error in "/home/elexis/code/0ad-svn/trunk/binaries/data/mods/public/art/actors/props/units/shields/aspis_lambda_agis.xml": mismatched tag: line 11, column 6

Posting the file to a random XML validation site like https://www.xmlvalidation.com/index.php?id=1&L=0

The element type "group" must be terminated by the matching end-tag "</group>".

Looking at it, the problem is double-closing the variant:

<variant... />
</variant>

Also unrelated to this commit, but the XML validation script spams 1 error and 1 warning for many files, in case someone reading this wants to do a mass change:

Error in "/path/to/trunk/binaries/data/mods/public/art/actors/units/persians/cavalry_javelinist_b_m.xml": actor does not contain required texture "baseTex" from "basic_trans_parallax_spec.xml"

Warning in "/path/to/trunk/binaries/data/mods/public/art/actors/structures/plot_field_temp.xml": actor contains unnecessary texture "specTex" from "basic_trans.xml"

Also unrelated to this commit, but the XML validation script spams 1 error and 1 warning for many files, in case someone reading this wants to do a mass change:

Error in "/path/to/trunk/binaries/data/mods/public/art/actors/units/persians/cavalry_javelinist_b_m.xml": actor does not contain required texture "baseTex" from "basic_trans_parallax_spec.xml"

Why it would mark this as bad while others cavalry_javelinist_x_m use the same variant textures? in any case i copied from cavalry_javelinist_a to _b and see if it fixes it.

Warning in "/path/to/trunk/binaries/data/mods/public/art/actors/structures/plot_field_temp.xml": actor contains unnecessary texture "specTex" from "basic_trans.xml"

Gonna see what purpose have this actor ingame and see if it needs spec map in a miscellaneous fixes committ

Jenkins says:

mismatched tag at line 11, column 6, byte 498 at /usr/lib/x86_64-linux-gnu/perl5/5.24/XML/Parser.pm line 187.

The source/tools/xmlvalidator/validator.py script locates:

Error in "/home/elexis/code/0ad-svn/trunk/binaries/data/mods/public/art/actors/props/units/shields/aspis_lambda_agis.xml": mismatched tag: line 11, column 6

Posting the file to a random XML validation site like https://www.xmlvalidation.com/index.php?id=1&L=0

The element type "group" must be terminated by the matching end-tag "</group>".

Looking at it, the problem is double-closing the variant:

<variant... />
</variant>

fixed for the shield and greaves assignation committ next to come. Thanks!

Why it would mark this as bad while others cavalry_javelinist_x_m use the same variant textures? in any case i copied from cavalry_javelinist_a to _b and see if it fixes it.

Check the attached logfile, it's marked for many files

Why it would mark this as bad while others cavalry_javelinist_x_m use the same variant textures? in any case i copied from cavalry_javelinist_a to _b and see if it fixes it.

It's none of my business but it appears that you can just ignore that...

Why it would mark this as bad while others cavalry_javelinist_x_m use the same variant textures? in any case i copied from cavalry_javelinist_a to _b and see if it fixes it.

Check the attached logfile, it's marked for many files

Looks like its related to variant files and not directly to actors.

Stan added a subscriber: Stan.Aug 20 2019, 7:18 PM

Sounds like you copy pasted a texture line and forgot to rename spectex to basetex or something.