Move static GUI<>::GetSetting operating on IGUIObject member to a IGUIObject member function, grouping it with SettingExists and AddSetting.
Differential Revision: https://code.wildfiregames.com/D2230
Tested on: gcc 9.1.0, Jenkins
Description
Description
Details
Details
- Committed
elexis Aug 26 2019, 2:25 PM - Differential Revision
- D2230: Move GUIUtil GetSetting to IGUIObject
- Parents
- rP22788: [i18n] Updated POT and PO files.
- Branches
- Unknown
- Tags
- Build Status
Buildable 9092 Build 14899: Trigger Windows Autobuild Build 14898: Post-Commit Build Jenkins
Event Timeline
Comment Actions
2010-07/2010-07-24-QuakeNet-#0ad-Meeting.log
14:10 < V0idExp> Hi! Can someone explain me how GUI<T> class is used and what it represents? 14:11 < V0idExp> I've noticed the GUI<SGUIMessage>::RecurseObject() call and can't figure out what is its purpose 14:18 <@Philip-> I think it represents a random collection of GUI-related functions that either take a template parameter or are used by other functions in that class 14:19 < V0idExp> Aaah... I thought it was some very strange interface to all GUI elements :D 14:19 <@Philip-> RecurseObject calls a function of the form "void IGUIObject::foo(T&)" recursively on the tree of GUI objects 14:19 <@Philip-> so it's kind of an interface in that way 14:19 <@Philip-> It's just static functions, you never have an object of type GUI<T> 14:20 < V0idExp> so, it's just an utility, right? 14:20 <@Philip-> Yeah 14:20 <@Philip-> which is why it's in GUIutil.h 14:21 <@Philip-> (I think it's fairly ugly) 14:22 <@Philip-> (but not enough to motivate me to rewrite it)