Delete 27 invalid style settings and add LOGWARNING to inform future authors.
rP22792
Actions

Description

Delete 27 invalid style settings and add LOGWARNING to inform future authors.

Unify the two IGUIObject::LoadStyle functions and remove CGUI argument that is always identical to the member.

Differential Revision: https://code.wildfiregames.com/D2232
Tested on: gcc 9.1.0., clang 8.0.1, Jenkins

Details

Committed

elexis

Aug 27 2019, 6:03 PM

Differential Revision

D2232: Report and delete wrong style settings

Parents

rP22791: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9098
Build 14911: Trigger Windows Autobuild
Build 14910: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22792: Delete 27 invalid style settings and add LOGWARNING to inform future authors..Aug 27 2019, 6:03 PM

elexis added an edge: D2232: Report and delete wrong style settings.

Harbormaster completed building B9098: rP22792: Delete 27 invalid style settings and add LOGWARNING to inform future authors..Aug 27 2019, 6:09 PM

elexis mentioned this in D2231: Move GUIUtil SetSetting to IGUIObject.Aug 27 2019, 6:15 PM

elexis mentioned this in rP22800: Delete invalid ModmodScrollbar style use and style property from rP15677 and….Aug 29 2019, 9:56 AM

When opening the save game dialog I get this warning

WARNING: GUI object has no setting "sprite_heading", but the style "ModernList" defines it

-> D2290

(It's because the style defines properties for COList but that dialog uses that style for an `CList, so either one insists on that being a feature and reverts this warning, specifies a new style for CList, or makes the COList feature available to the other dialog too, and in that case one can fix it by deleting the entire folder (ok, moving few lines of code over).)

elexis mentioned this in D2297: Report and tolerate errors when parsing strings as values for settings that don't exist.Sep 16 2019, 5:50 PM

elexis mentioned this in rP22923: Unify loadgame and savegame dialog following rP13579, refs #2030..Sep 18 2019, 4:34 AM