HomeWildfire Games

Fix the issue with the formations and groups in actors And some corrections to…
AuditedrP22839

Description

Fix the issue with the formations and groups in actors And some corrections to variants.

Details

Auditors
Freagarach
Committed
AlexandermbTue, Sep 3, 5:21 PM
Parents
rP22838: Fix the indent in rP22837
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9206
Build 15147: Post-Commit BuildJenkins

Event Timeline

@elexis can you confirm this fix both the corinthian helmet issue and @Freagarach build issue ?

In rP22839#37331, @Stan wrote:

@elexis can you confirm this fix both the corinthian helmet issue and @Freagarach build issue ?

Build issue solved :)
Thanks both!

Freagarach raised a concern with this commit.Tue, Sep 3, 8:53 PM

ERROR: Could not load animation 'art/animation/biped/infantry/swordsman/idle_relax_shieldsmall.dae'
ERROR: CSkeletonAnimManager::GetAnimation(art/animation/biped/infantry/swordsman/idle_relax_shieldsmall.dae): Failed loading, marked file as bad

This commit now has outstanding concerns.Tue, Sep 3, 8:54 PM

units/pers_champion_infantry...
ERROR: Could not load animation 'art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae'
ERROR: CSkeletonAnimManager::GetAnimation(art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae): Failed loading, marked file as bad

units/pers_champion_infantry...
ERROR: Could not load animation 'art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae'
ERROR: CSkeletonAnimManager::GetAnimation(art/animation/biped/infantry/spearman/run_ready_shield_shieldsmall.dae): Failed loading, marked file as bad

Can you check if this was fixed with the latest changes? my internet have been worst this days.

Can you check if this was fixed with the latest changes? my internet have been worst this days.

This was at rP22844, the issues I raised a concern about are fixed :)
No worries, take your time!

Freagarach accepted this commit.Thu, Sep 5, 7:43 AM

My concerns were fixed in rP22849, thanks @Alexandermb!

All concerns with this commit have now been addressed.Thu, Sep 5, 7:43 AM
In rP22839#37331, @Stan wrote:

@elexis can you confirm this fix both the corinthian helmet issue and @Freagarach build issue ?

I've teted with chicken gathering quickly:

  • The helmet of the unit is visible during the slaughter animation
  • Helmet / Hat invisible during gathering and return resource

I suppose its not a big issue, we can create a trac backlog ticket if you have things to do, I reported it as it was reported to me and technically its a valid report.

Stan added a comment.Thu, Sep 5, 11:33 AM
In rP22839#37331, @Stan wrote:

@elexis can you confirm this fix both the corinthian helmet issue and @Freagarach build issue ?

I've teted with chicken gathering quickly:

  • The helmet of the unit is visible during the slaughter animation
  • Helmet / Hat invisible during gathering and return resource

I suppose its not a big issue, we can create a trac backlog ticket if you have things to do, I reported it as it was reported to me and technically its a valid report.

It is I told @Alexandermb. If it's not fixed next week i'll fix it then (mostly afk these days)

I've teted with chicken gathering quickly:

  • The helmet of the unit is visible during the slaughter animation
  • Helmet / Hat invisible during gathering and return resource

I suppose its not a big issue, we can create a trac backlog ticket if you have things to do, I reported it as it was reported to me and technically its a valid report.

Removed helmet during slaughter animation in the variant file in this commit rP22852 i guess the actor was having the helmet removal in the group itself.

elexis added a comment.Thu, Sep 5, 3:14 PM

seleucid citizensoldier infantry spearman
I don't know which commit it was.

https://code.wildfiregames.com/rP21984#37228

elexis added a comment.Thu, Sep 5, 3:16 PM

I don't know if there is a logic behind it, but I suppose the bugreport by ValihrAnt that I relayed was that the player expects the helmet to not disappear during animations.
The seleucid infantry spearman hat, I suppose that is not the corinthian helmet, I still don't know which visual actor commit that is, is only a small hat, so I suppose its not a problem to always show it intead of showing it in only some states.

Stan added a comment.Thu, Sep 5, 4:38 PM

The gathering and carrying variants being used by all the units it's actually easy to make them appear or disappear for everyone. Usually you have 10 files tops to change.

Build issue solved :)
Thanks both!

Fixes #5579.