HomeWildfire Games

standardized hero aura descriptions

Description

standardized hero aura descriptions

Summary:
This patch rephrases the aura descriptions of hero auras to an uniform standard, to ensure descriptions follow the actual modifications: [player] [class] [change] [attributes], e.g. "Spearmen +1 capture attack strength, +25% melee attack damage." instead of "+25% attack and +1 capture for spear soldiers."

See also D1720, D1806, D1807.

The formation and garrison type aura descriptions are ugly; improvement suggestions are welcome.

Test Plan: Check for mistakes and omissions.

Reviewers: Gallaecio, Freagarach

Reviewed By: Gallaecio, Freagarach

Subscribers: Freagarach, elexis, Vulcan

Differential Revision: https://code.wildfiregames.com/D1808

Details

Committed
GallaecioSep 15 2019, 1:48 PM
Reviewer
Gallaecio
Differential Revision
D1808: standardized hero aura descriptions
Parents
rP22904: manual/intro.txt corrections
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9392
Build 15605: Post-Commit BuildJenkins

Event Timeline

Stan added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/data/auras/units/heroes/ptol_hero_cleopatra_1.json
10

From @psypherium

I guess "-%20 attack repeat time" is actually a bonus
it would be more intuitive to re-word that to be a "+"
"+20 attack repeat speed"
Bonuses should almost always be phrased as a positive, not a negative