HomeWildfire Games

Move palisades from other/ to structures/

Description

Move palisades from other/ to structures/

Following D1881 which introduced a common parent, palisade templates can be moved:

  • other/palisades_rocks_* to structures/palisades_*
  • other/palisades_*_spike* to structures/palisades_spike*

Map scripts were updated accordingly.

Patch By: Nescio

Reviewed By: wraitii

Refs #4770

Differential Revision: https://code.wildfiregames.com/D2234

Details

Committed
wraitiiSep 23 2019, 9:48 AM
Reviewer
wraitii
Differential Revision
D2234: move palisades from other/ to structures/
Parents
rP22981: [i18n] Updated POT and PO files.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9569
Build 16005: Post-Commit BuildJenkins

Event Timeline

Nescio added a subscriber: Nescio.Sep 23 2019, 10:51 AM

Out of curiosity, why did you decide to keep the final s? https://code.wildfiregames.com/D2234?id=9536 moved the templates to palisade_*, without s.

Out of curiosity, why did you decide to keep the final s? https://code.wildfiregames.com/D2234?id=9536 moved the templates to palisade_*, without s.

To be honest I pretty much redid the moves from scratch to apply the patch, and I didn't really notice the palisade vs palisades thing. So not really a conscious thing.

Though palisade without s would be more correct; wall, gate, fence are not pluralized either. And stables was finally corrected to stable a couple of months ago.

elexis added a subscriber: elexis.Sep 23 2019, 5:29 PM

I pretty much redid the moves from scratch to apply the patch

(welcome to the club)

Though palisade without s would be more correct; wall, gate, fence are not pluralized either. And stables was finally corrected to stable a couple of months ago.

(rP22320, rP22328)