HomeWildfire Games

Always inform clients why the server chose to disconnect them, i.e. stop using…

Description

Always inform clients why the server chose to disconnect them, i.e. stop using NDR_UNKNOWN as a disconnect reason when the reason is known and add a LOGWARNING for future authors.

Differential Revision: https://code.wildfiregames.com/D1561
Tested on: clang 8.0.1, Jenkins

Event Timeline

wraitii added a subscriber: wraitii.Nov 9 2020, 9:21 AM
wraitii added inline comments.
/ps/trunk/source/network/NetSession.cpp
126

This function appears to be entirely unused. I guess the client never voluntarily disconnects from the host, unless it's destroyed (and the destructor didn't use it).