HomeWildfire Games
Diffusion 0 A.D. Public Repository rP23062

Rewrite session chat to use hierarchical object oriented design using class…
rP23062
Actions

Description

Rewrite session chat to use hierarchical object oriented design using class syntax, refs #5387.

Set global hotkeys in JS instead of empty XML objects from rP22851/D2260.

Differential Revision: https://code.wildfiregames.com/D2355

Details

Committed
elexisOct 6 2019, 4:42 PM
Differential Revision
D2355: Rewrite session chat to use class syntax / object-oriented programming
Parents
rP23061: [Windows] Automated build.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9757
Build 16401: Post-Commit BuildJenkins

Event Timeline

elexis committed rP23062: Rewrite session chat to use hierarchical object oriented design using class….Oct 6 2019, 4:42 PM
elexis added an edge: D2355: Rewrite session chat to use class syntax / object-oriented programming.
Harbormaster failed to build B9757: rP23062: Rewrite session chat to use hierarchical object oriented design using class…!Oct 6 2019, 4:50 PM
Polakrity added a subscriber: Polakrity.Dec 2 2019, 10:38 PM
Polakrity added inline comments.
/ps/trunk/binaries/data/mods/public/gui/session/chat/ChatMessageFormatPlayer.js
57

Currently we extract a "no-context" string.
Notified on Transifex.

elexis added inline comments.Dec 5 2019, 12:02 PM
/ps/trunk/binaries/data/mods/public/gui/session/chat/ChatMessageFormatPlayer.js
57

See discussion in D2451.

Langbart mentioned this in D4621: Fix chat window.Apr 27 2022, 3:02 AM
Silier mentioned this in rP26842: Fix chat window.Apr 29 2022, 7:48 PM

Changes (19)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/
chat/
hotkeys/

rP23062

View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/Chat.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatAddressees.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatHistory.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatInput.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatMessageFormatNetwork.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatMessageFormatPlayer.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatMessageFormatSimulation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatMessageHandler.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatOverlay.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/ChatWindow.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat/chat_window.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/chat_window.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/developer_overlay.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/hotkeys/misc.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/menu.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/messages.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.xml

Loading...
Wildfire Games · Phabricator