HomeWildfire Games
Diffusion 0 A.D. Public Repository rP23114

SessionMessageBox class, refs #5387.
rP23114
Actions

Description

SessionMessageBox class, refs #5387.

Decouples events from event handling, removes implicit-pause duplication per messagebox and allows mods to modify message box values.

Differential Revision: https://code.wildfiregames.com/D2398
Comments By: Stan, Freagarach

Details

Committed
elexisOct 30 2019, 12:14 PM
Differential Revision
D2398: Abstract and decouple SessionMessageBox
Parents
rP23113: Fix performance improvement (50 microsec/call) valuesetting missing in…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 9902
Build 16693: Post-Commit BuildJenkins

Event Timeline

elexis committed rP23114: SessionMessageBox class, refs #5387..Oct 30 2019, 12:14 PM
elexis added an edge: D2398: Abstract and decouple SessionMessageBox.
Harbormaster completed building B9902: rP23114: SessionMessageBox class, refs #5387..Oct 30 2019, 12:18 PM
elexis added inline comments.Nov 6 2019, 3:37 PM
/ps/trunk/binaries/data/mods/public/gui/session/message_box/OutOfSyncReplay.js
28

translate -> translateWithContext

elexis mentioned this in D2409: GuiInterface TimeNotifications fixes and cleanup.Nov 6 2019, 9:26 PM

Changes (16)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
session/
developer_overlay/

rP23114

View Options

ps/trunk/binaries/data/mods/public/gui/session/MenuButtons.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/SessionMessageBox.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/developer_overlay/TimeWarp.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/DeleteSelectionConfirmation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/OutOfSyncNetwork.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/OutOfSyncReplay.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/QuitConfirmation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/QuitConfirmationDefeat.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/QuitConfirmationMenu.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/QuitConfirmationReplay.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/message_box/ResignConfirmation.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/messages.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

Loading...
Wildfire Games · Phabricator