HomeWildfire Games

Rename CProgressBar numeric "caption" setting to "progress" to distinguish it…

Description

Rename CProgressBar numeric "caption" setting to "progress" to distinguish it from the Button, Input, Text and Tooltip "caption" setting values that are tag-formatted texts.

Remove TODO question from rP1232 since the class updates correctly.

Differential Revision: https://code.wildfiregames.com/D2419
Tested on: clang 9.0.0, Jenkins/gcc6, Jenkins/vs2015

Event Timeline

Silier raised a concern with this commit.Nov 12 2019, 7:10 PM
Silier added a subscriber: Silier.
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/gui/loading/ProgressBar.js
29

ERROR: JavaScript error: gui/loading/ProgressBar.js line 29 ReferenceError: reference to undefined property "progress"

This commit now has outstanding concerns.Nov 12 2019, 7:10 PM
Silier resigned from this commit.Nov 12 2019, 7:18 PM

sorry, i missed cpp changes

This commit no longer requires audit.Nov 12 2019, 7:18 PM