HomeWildfire Games

Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was…

Description

Bolt tower and ampitheater commit, updated ptolemaic sentry tower while I was at it, and radiant flame texture added for directionless fire effects, babylonian tower template switched to persian denomination for potential upgradeability

https://wildfiregames.com/forum/index.php?/topic/27156-artillery-towers/page/2/&tab=comments#comment-388362
https://wildfiregames.com/forum/index.php?/topic/27230-pompeii-ampitheater/&tab=comments#comment-387990

Event Timeline

minohaka raised a concern with this commit.Nov 18 2019, 6:20 AM
minohaka added a subscriber: minohaka.

Tried a match and got these:
ERROR: CCacheLoader failed to find archived or source file for: "simulation/templates/template_structure_defense_tower_stone.xml"
ERROR: Failed to load parent 'template_structure_defense_tower_stone' of entity template 'structures/union_blockhouse'
ERROR: Failed to load entity template 'structures/union_blockhouse'

This commit now has outstanding concerns.Nov 18 2019, 6:20 AM
Nescio added a subscriber: Nescio.Nov 18 2019, 11:21 AM

Furthermore, “amphitheatre” (ἀμφιθέατρον) is written with a ph, not a p; please correct.

ffffffff added a subscriber: ffffffff.EditedNov 18 2019, 2:12 PM

Furthermore, “amphitheatre” (ἀμφιθέατρον) is written with a ph, not a p; please correct.

not with a "pi" pls keep serious

elexis raised a concern with this commit.Nov 26 2019, 10:17 AM
elexis added a subscriber: elexis.
elexis added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/templates/structures/ptol_tower_bolt.xml
8

structure tree with selecting ptol points out

WARNING: The "structures/ptol_tower_bolt" template has a defined civ of "spart". This does not match the currently selected civ "ptol".
/ps/trunk/binaries/data/mods/public/simulation/templates/structures/spart_tower_bolt.xml
8

same

Angen added a subscriber: Angen.Nov 26 2019, 10:32 AM
Angen added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/templates/structures/cart_tower_bolt.xml
8

here

/ps/trunk/binaries/data/mods/public/simulation/templates/structures/spart_tower_bolt.xml
8

this is sparta ;)

Nescio added a comment.EditedDec 17 2019, 8:25 PM

It's possible to upgrade existing defense towers to bolt towers, however, it is not possible to build them directly. Because the AI never upgrades anything, this gives an unfair advantage to human players. Besides, not all factions have them, further affecting gameplay balance.
Therefore I think it's better to remove these upgrades; keep these towers for mods and scenarios, but don't make them available by default, at least not until proper discussion and gameplay testing; cf. practice ranges and stables added last year.

The concern by minohaka was fixed in rP23161.

The warning that appears everytime one opens the structree and select Cart or Ptol was fixed in rP23328.

WARNING: The "structures/cart_tower_bolt" template has a defined civ of "spart". This does not match the currently selected civ "cart". WARNING: The "structures/ptol_tower_bolt" template has a defined civ of "spart". This does not match the currently selected civ "ptol".

Since the fix was very easy and the warning very blatant and repetitive, I don't understand why it hadn't been fixed, but I guess that's how it is.

This commit no longer requires audit.Jan 4 2020, 5:08 PM