HomeWildfire Games
Diffusion 0 A.D. Public Repository rP23239

Allow modders to play an animation when objects with production queues are…
rP23239
Actions

Description

Allow modders to play an animation when objects with production queues are researching techs.
Reviewed by: @Angen
Comments by: @Krinkle, @bb
Thread: https://wildfiregames.com/forum/index.php?/topic/27329-visual-feedback-for-researching/&tab=comments#comment-389598

Differential Revision: https://code.wildfiregames.com/D2459

Details

Committed
StanDec 14 2019, 9:49 PM
Reviewer
Silier
Differential Revision
D2459: Play an animation when buildings a researching techs.
Parents
rP23238: Move hardcoded gain per garrisoned trader on ship to template
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10318
Build 17580: Post-Commit BuildJenkins

Event Timeline

Stan committed rP23239: Allow modders to play an animation when objects with production queues are….Dec 14 2019, 9:49 PM
Stan added an edge: D2459: Play an animation when buildings a researching techs..
Stan added subscribers: Krinkle, Silier, bb.
Harbormaster completed building B10318: rP23239: Allow modders to play an animation when objects with production queues are….Dec 14 2019, 9:52 PM
Silier mentioned this in rP23185: Allow artists to add upgrade animations..Jan 7 2020, 6:32 PM
elexis raised a concern with this commit.EditedJan 7 2020, 6:37 PM
elexis added a subscriber: elexis.

See former concern at rP23185 when researching + upgrading simultaneously, which probably should be prohibited in the first place, since the upgraded entity may not have a ProductionQueue or not that tech in the ProductionQueue (see #2706).

This commit now has outstanding concerns.Jan 7 2020, 6:37 PM
Silier mentioned this in D2652: Do not allow upgrading when entity is producing and vice versa..Mar 15 2020, 12:51 PM
wraitii removed an auditor: elexis.Dec 28 2020, 10:52 AM
wraitii added a subscriber: wraitii.

Limitations of the animation system aren't a code concern. Further, the above is now indeed not allowed.

This commit no longer requires audit.Dec 28 2020, 10:52 AM

Changes (1)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/

rP23239

View Options

ps/trunk/binaries/data/mods/public/simulation/components/ProductionQueue.js

Loading...
Wildfire Games · Phabricator