Fix User Reporter worker thread always using a full CPU-Thread
rP23259
Actions

Description

Fix User Reporter worker thread always using a full CPU-Thread

Summary:
This bug was introduced in rP22772.
Fixed by not using the predicate of the wait command.
It was wrong and even if it was right it wouldn't be really usefull.

Reviewed by: Angen

Fixes: #5620

Differential Revision: https://code.wildfiregames.com/D2373

Details

Committed

Imarok

Dec 18 2019, 6:19 PM

Reviewer

Silier

Differential Revision

D2373: Fix the waiting of the User Reporter worker thread

Parents

rP23258: Remove some unused old helper images as they shouldn't be packaged.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10364
Build 17673: Trigger Windows Autobuild
Build 17672: Post-Commit Build	Jenkins

Event Timeline

Imarok committed rP23259: Fix User Reporter worker thread always using a full CPU-Thread.Dec 18 2019, 6:19 PM

Imarok added an edge: D2373: Fix the waiting of the User Reporter worker thread.

Imarok mentioned this in rP22772: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.Dec 18 2019, 6:24 PM

Harbormaster completed building B10364: rP23259: Fix User Reporter worker thread always using a full CPU-Thread.Dec 18 2019, 6:30 PM

Changes (1)

Path

Size

ps/

trunk/

source/

ps/

UserReport.cpp

rP23259

View Options

ps/trunk/source/ps/UserReport.cpp