Diffusion 0 A.D. Public Repository rP23298

Automatically cancel packing or unpacking based on given order
rP23298
Actions

Tags

None

Subscribers

Description

Automatically cancel packing or unpacking based on given order

Cancel packing when next command requires unpacked state and cancel unpacking when next command requires packed state.

Fixing unit refusing to move because keeps unpacking to attack targets in range.

Partially Fixes: #4015, #5328
Differential Revision: https://code.wildfiregames.com/D1520
Patch by: @causative
Comments by: elexis, Freagarach, Stan

Details

Committed

Dec 28 2019, 12:40 PM

Differential Revision

D1520: Automatically cancel unpacking when units are ordered to move

Parents

rP23297: Inform player that second market is too close to setup trade route

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10547
Build 18090: Post-Commit Build	Jenkins

Event Timeline

Silier committed rP23298: Automatically cancel packing or unpacking based on given order.Dec 28 2019, 12:40 PM

Silier added an edge: D1520: Automatically cancel unpacking when units are ordered to move.

Silier added a subscriber: causative.

Harbormaster completed building B10547: rP23298: Automatically cancel packing or unpacking based on given order.Dec 28 2019, 12:46 PM

Thanks for the fix.

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
147	Globals should be avoided, because they are accessible to any simulation script but only relevant for one component, so better put them into the protoype.
5161	(&& has higher operator precedence than \|\| so the inner parentheses are not needed)

Freagarach mentioned this in rP21630: Fix UnitAI behaviour inconsistent with its stance for packed units and set….Mar 25 2020, 8:39 AM

Refs. #1752.

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

rP23298

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...