HomeWildfire Games

[gui] building → structure

Description

[gui] building → structure

Summary:
This patch corrects occurrences of “building” into “structure”.
Whilst “constructing a building” is proper English, it is important to refer to one and the same thing with a single term, to avoid potential misunderstandings (see https://trac.wildfiregames.com/wiki/EnglishStyleGuide ), thence “building a structure”, because the unit action is “build” and the entity is a “structure” (see simulation/templates/).

Test Plan: Check for mistakes and omissions.

Reviewers: Gallaecio

Reviewed By: Gallaecio

Subscribers: Freagarach, O8 JS GUI

Differential Revision: https://code.wildfiregames.com/D2429

Details

Event Timeline

In rP23366#40710, @Stan wrote:

Patch by: @Nescio

I’m currently simply using “arc patch <revision>” and ”arc commit --revision <revision>”. What should I do to make sure the commit message mentions Nescio as author?¿ Manually edit the message before committing?

elexis added a subscriber: elexis.Jan 11 2020, 2:37 PM

Yes. Also these fields can also be dropped from the commit message except where someone else reviewed additionally (as someone committing a patch takes responsibility for the content, so should have reviewed it, so the information is redundant. If someone else reviewed additionally, that should be credited with Reviewed By: foo). (Also the summary sometimes isn't representative of the final patch anymore if it changed during the course of the lifespan of the revision proposal, or sometimes the summary isn't too well written, or too elaborative or comes short of explaining relevant things)

Reviewers: Gallaecio
Reviewed By: Gallaecio
Subscribers: Freagarach, O8 JS GUI

Test Plan: Check for mistakes and omissions.

Usually we don't add the test plan to commit messages either (And this one in specific doesn't contain any information at all)

(and at last the word Summary: is unnecessary)

(Not that it matters much)