HomeWildfire Games

Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea…
AuditedrP23392

Description

Landscape and Daytime gamesetup options for the Unknown, Danubius and Polar Sea, refs #4838.

Allow gamesetup options other than biome to determine the map peview image, refs #4962, rP21523.
Add previews for the 12 Unknown, 2 Danubius and 2 Polar Sea variations.
Concludes deduplication of the Unknown (rP12545), Unknown Land (rP12654) and Unknown Nomad (rP12747), refs #4317.

Differential Revision: https://code.wildfiregames.com/D2564

Event Timeline

bb raised a concern with this commit.Jan 14 2020, 12:17 PM
bb added a subscriber: bb.

When starting a SP match

ERROR: JavaScript error: gui/gamesetup/GameSettings/Single/Dropdowns/Landscape.js line 97
TypeError: this.mapData is undefined
  onPickRandomItems@gui/gamesetup/GameSettings/Single/Dropdowns/Landscape.js:97:7
  pickRandomItems@gui/gamesetup/Controls/GameSettingsControl.js:247:4
  onLaunchGame@gui/gamesetup/Controls/GameSettingsControl.js:255:3
  launchGame@gui/gamesetup/Controls/StartGameControl.js:35:4
  onPress@gui/gamesetup/Panels/Buttons/StartGameButton.js:61:3

isn't due to matchsettingsfile

This commit now has outstanding concerns.Jan 14 2020, 12:17 PM
elexis added a comment.EditedJan 14 2020, 2:59 PM

Do you have a replay for that match? Or do you know which map it was? I cant reproduce with or without the persist file for skirmish maps, random maps and the unknown map, nor tutorial.

(Until then unverifiable patch

)

bb added a comment.Jan 14 2020, 7:15 PM

The random Random map ;)

elexis requested verification of this commit.Jan 15 2020, 12:51 PM
This commit now requires verification by auditors.Jan 15 2020, 12:51 PM
bb accepted this commit.Jan 21 2020, 4:55 PM

bug disappeared

All concerns with this commit have now been addressed.Jan 21 2020, 4:55 PM