Diffusion 0 A.D. Public Repository rP23419

Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move…
rP23419
Actions

Description

Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move it to the Gamesetup subfolder context, refs #5322, #5387.

This establishes a code architecture where only one class and only one page is responsible per AI setting,
removes the hardcodings from the XML and JS file,
allowing future patches and mods to insert, remove and edit independent AI settings without having to overwrite the existing code.

Differential Revision: https://code.wildfiregames.com/D2577
See also rP23413/D2581 and comments linked there.

Details

Committed

elexis

Jan 20 2020, 10:29 AM

Differential Revision

D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder

Parents

rP23418: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10889
Build 19086: Post-Commit Build	Jenkins
Build 19085: Post-Commit Build (macOS)	Jenkins

Event Timeline

elexis committed rP23419: Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move….Jan 20 2020, 10:29 AM

elexis added an edge: D2577: Use class syntax for AIConfig page and move it to Gamesetup/Pages subfolder.

Harbormaster completed building B10889: rP23419: Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move….Jan 20 2020, 10:41 AM

Also:
Removes the hack to Pop and Push the dialog in order to update it.
Update the gameAttributes instantly when changing an AI dropdown, so that the selection isnt lost when another client changes any game setting, preparing for #3806.

Silier added a subscriber: Silier.Oct 15 2020, 7:44 PM

Silier added inline comments.

/ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js
31	this.playerIndex is undefined for #5844

Silier mentioned this in D3038: Fix handling of fixed ai defined by map after rP23419.Oct 15 2020, 8:16 PM

Silier mentioned this in rP24109: Fix handling of fixed ai defined by map after rP23419.Oct 24 2020, 2:14 PM

Changes (39)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

aiconfig.xml

gamesetup/

Pages/

AIConfigPage

AIDescription.js

AIGameSettingControl.js

GameSetupPage/

GameSettings/

GameSettingControl.js

GameSettingControlManager.js

PerPlayer/

AIConfigButton.js

PlayersPanel.xml

PlayerSettingControlManager.js

GameSetupPage.js

Panels/

Buttons/

Chat/

ChatMessages/

GameSettingsChanged.js

ChatPanel.js

GameDescription.js

GameSettingWarning.js

LoadingPage/

	gamesetup/	Pages/	AIConfigPage/
			aiconfig/

	AIConfigPage.js
	aiconfig.js

	AIConfigPage.xml
	aiconfig.xml

page_aiconfig.xml

l10n/

Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move…rP23419Actions

Description

Details

Event Timeline

Changes (39)

rP23419

ps/trunk/binaries/data/mods/public/gui/aiconfig/

ps/trunk/binaries/data/mods/public/gui/aiconfig/aiconfig.js

ps/trunk/binaries/data/mods/public/gui/aiconfig/aiconfig.xml

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIConfigPage.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIConfigPage.xml

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIDescription.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/AIGameSettingControl.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIBehavior.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AIDifficulty.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/AIConfigPage/Controls/AISelection.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/GameSettingControl.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/GameSettingControlManager.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/AIConfigButton.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PerPlayer/PlayersPanel.xml

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/PlayerSettingControlManager.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSetupPage.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/CancelButton.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/ReadyButton.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/ResetCivsButton.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/ResetTeamsButton.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Buttons/StartGameButton.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientChat.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientConnection.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientKicked.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/ClientReady.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatMessages/GameSettingsChanged.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/Chat/ChatPanel.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/GameDescription.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/GameSettingWarning.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/GameSettingsPanel.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/MapPreview.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/Panels/SoundNotification.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/LoadingPage/LoadingPage.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/SetupWindow.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.xml

ps/trunk/binaries/data/mods/public/gui/page_aiconfig.xml

ps/trunk/binaries/data/mods/public/l10n/messages.json

Rewrite Gamesetup AIConfig page to use class syntax, decouple settings and move…
rP23419
Actions