Support random map script tests, fixes #4827.
Differential Revision: https://code.wildfiregames.com/D2085
Comments By: wraitii
Description
Description
Details
Details
- Committed
elexis Jan 29 2020, 1:30 AM - Differential Revision
- D2085: Support RandomMap tests
- Parents
- rP23454: Disband formation instead destroying
- Branches
- Unknown
- Tags
- Build Status
Buildable 10988 Build 19400: Trigger Windows Autobuild Build 19399: Post-Commit Build Jenkins Build 19398: Post-Commit Build (macOS) Jenkins
Event Timeline
Comment Actions
With the patch:
Running cxxtest tests (336 tests)..... In TestMapGenerator::test_mapgen_scripts: /build/0ad-0.0.24~r23514/source/graphics/tests/test_MapGenerator.h:42: Error: Expected ((vfs::GetPathnames(g_VFS, L"maps/random/tests/", L"test_*.js", paths)) == INFO::OK), found (-110100 != 0) .................................................................................................................................................................................................................................... In TestComponentScripts::test_global_scripts: /build/0ad-0.0.24~r23514/source/simulation2/components/tests/test_scripts.h:62: Error: Expected ((vfs::GetPathnames(g_VFS, L"globalscripts/tests/", L"test_*.js", paths)) == INFO::OK), found (-110100 != 0) WARNING: Skipping component scripts tests (can't find binaries/data/mods/public/simulation/components/tests/setup.js) ..................................................................................................... Failed 2 and Skipped 0 of 336 tests
Without the patch (A23B):
08:45 < ricotz> Running cxxtest tests (312 tests).................................................................................................................................................................................................................................WARNING: Skipping component scripts tests (can't find binaries/data/mods/public/simulation/components/tests/setup.js) 08:45 < ricotz> .......................................................................................OK!
As reported by @ricotz on IRC it breaks the tests when running without the public mod, which was still possible in A23B.
| /ps/trunk/source/graphics/tests/test_MapGenerator.h | ||
|---|---|---|
| 41 | Missing: if (!VfsFileExists(L"simulation/components/tests/setup.js")) { debug_printf("WARNING: Skipping component scripts tests (can't find binaries/data/mods/public/simulation/components/tests/setup.js)\n"); return; } | |
Comment Actions
According to ricotz today on IRC, it is "fixed". http://irclogs.wildfiregames.com/2020-04/2020-04-23-QuakeNet-%230ad-dev.log