Diffusion 0 A.D. Public Repository rP23465

Unify GetRange calls in UnitAI.
rP23465
Actions

Description

Unify GetRange calls in UnitAI.

This patch unifies the different GetRange calls to one function in UnitAI. Split from D1958 and makes further changes to be done easier at one place.

Differential Revision: https://code.wildfiregames.com/D2328
Patch by: @Freagarach

Details

Committed

Silier

Jan 30 2020, 10:05 PM

Differential Revision

D2328: Unify GetRange calls in UnitAI.

Parents

rP23464: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 11009
Build 19459: Post-Commit Build	Jenkins
Build 19458: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP23465: Unify GetRange calls in UnitAI..Jan 30 2020, 10:05 PM

Silier added an edge: D2328: Unify GetRange calls in UnitAI..

Silier added a subscriber: Freagarach.

Harbormaster failed to build B11009: rP23465: Unify GetRange calls in UnitAI.!Jan 30 2020, 10:52 PM

Silier added a subscriber: elexis.Jan 31 2020, 8:28 PM

Silier added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js
5808	if (!range) return ret; reported https://trac.wildfiregames.com/ticket/5666#comment:4 by @elexis

Silier mentioned this in D2608: Fix checks for range existence following rP23465 .Jan 31 2020, 8:43 PM

Silier mentioned this in rP23471: Fix checks for range existence following rP23465.Jan 31 2020, 9:00 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Attack.js

UnitAI.js

rP23465

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Attack.js