HomeWildfire Games

Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190.

Description

Update cppformat from v0.11.0 to v1.1.0, fixes #5646, refs #3190.
Use the opportunity to rename the lib from cppformat to fmt, refs #4148.

Patch By: adrian
Rebased By: s0600204
Differential Revision: https://code.wildfiregames.com/D2613

Event Timeline

Stan added a subscriber: Stan.Apr 29 2020, 1:55 PM

I get this on my RPI4. Did we forget to set the locale in the test?

 0ad/binaries/system/test 
Running cxxtest tests (336 tests)...No SSE available. Slow fallback routines will be used.
...........................................................................................................................................................................................
In TestFmt::test_basic:
/media/pi/844df88a-3cff-4625-be92-09d7028b5f934/0ad/source/ps/tests/test_fmt.h:39: Error: Expected (fmt::sprintf("%f", 0.5f) == "0.500000"), found ("0,500000" != 0.500000)
/media/pi/844df88a-3cff-4625-be92-09d7028b5f934/0ad/source/ps/tests/test_fmt.h:40: Error: Expected (fmt::sprintf("%.1f", 0.1111f) == "0.1"), found ("0,1" != 0.1)
.................................................................................................................................................
Failed 1 and Skipped 0 of 336 tests
Success rate: 99%
 ✘ pi@raspberrypi  /media/pi/844df88a-3cff-4625-be92-09d7028b5f934  locale
LANG=fr_FR.UTF-8
LANGUAGE=fr_FR.UTF-8
LC_CTYPE="fr_FR.UTF-8"
LC_NUMERIC="fr_FR.UTF-8"
LC_TIME="fr_FR.UTF-8"
LC_COLLATE="fr_FR.UTF-8"
LC_MONETARY="fr_FR.UTF-8"
LC_MESSAGES="fr_FR.UTF-8"
LC_PAPER="fr_FR.UTF-8"
LC_NAME="fr_FR.UTF-8"
LC_ADDRESS="fr_FR.UTF-8"
LC_TELEPHONE="fr_FR.UTF-8"
LC_MEASUREMENT="fr_FR.UTF-8"
LC_IDENTIFICATION="fr_FR.UTF-8"
LC_ALL=fr_FR.UTF-8
Stan added a comment.May 6 2020, 10:44 AM

I get this on my windows

C:\Dev\trunk\source\simulation2\tests\test_Serializer.h:145: Error: Expected (std::string(stream.str()) == std::string("# comment
" "i8: -123
" "u8: 255
" "i16: -12345
" "u16: 56789
" "i32: -123
" "u32: 4294967173
" "float: 1e+30
" "double: 1.0000000000000001e+300
" "fixed: 1234.5
" "t: true
" "f: false
" "string: "example"
" "string 2: "example\\"\\\\\\""
" "string 3: "example\
\
test"
" "string 4: "t\xC3\xAAst"
" "raw bytes: (6 bytes) 00 01 02 03 0f 10
")), found ("# comment
i8: -123
u8: 255
i16: -12345
u16: 56789
i32: -123
u32: 4294967173
float: 1e+30
double: 1e+300
fixed: 1234.5
t: true
f: false
string: "example"
string 2: "example\\"\\\\\\""
string 3: "example\
\
test"
string 4: "têst"
raw bytes: (6 bytes) 00 01 02 03 0f 10
" != "# comment
i8: -123
u8: 255
i16: -12345
u16: 56789
i32: -123
u32: 4294967173
float: 1e+30
double: 1.0000000000000001e+300
fixed: 1234.5
t: true
f: false
string: "example"
string 2: "example\\"\\\\\\""
string 3: "example\
\
test"
string 4: "têst"
raw bytes: (6 bytes) 00 01 02 03 0f 10
")