HomeWildfire Games

Allow specific garrison points to receive only specific units, for instance…
AuditedrP23630

Description

Allow specific garrison points to receive only specific units, for instance catapults on ships, or having both visible garrison points for fortresses and garrisonning elephants.

Reviewed by: @Freagarach,
Comments by: @elexis, @Angen

Fixes #3488

Details

Event Timeline

It might be something with this commit, but in the following replay the CC of player 2 has an arrow count of -13. I will investigate.

Freagarach raised a concern with this commit.Jun 6 2020, 8:26 AM

^ I'm working on a fix.

/ps/trunk/binaries/data/mods/public/simulation/components/GarrisonHolder.js
271

There was a reason this was in PerformGarrison instead of in Garrison. ProductionQueue's autogarrison calls PerformGarrison directly instead of Garrison. Which could be seen as a bug in PQ instead of here.

This commit now has outstanding concerns.Jun 6 2020, 8:26 AM
Freagarach accepted this commit.Jun 6 2020, 12:25 PM

My concern was fixed in rP23743.

All concerns with this commit have now been addressed.Jun 6 2020, 12:25 PM