Diffusion 0 A.D. Public Repository rP23701

Implement keyDown event
AuditedrP23701
Actions

Description

Implement keyDown event
Change HotkeyPress event to be non-repeating (HotkeyDown to replace the repeating case)
Fix shiftlag
Make toggle hotkeys only respond to the first SDL event.

Many iterations of review by: elexis

Test done by: Imarok
Comments By: vladislav, Stan
Reviewed By: wraitii
Fixes: #5055
Differential Revision: https://code.wildfiregames.com/D1398

Details

Auditors

nani

Committed

bb	May 26 2020, 11:47 PM

Reviewer

wraitii

Differential Revision

D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating

Parents

rP23700: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 11836
Build 22083: Trigger Windows Autobuild
Build 22082: Post-Commit Build	Jenkins
Build 22081: Post-Commit Build (macOS)	Jenkins

Event Timeline

bb committed rP23701: Implement keyDown event .May 26 2020, 11:47 PM

bb added an edge: D1398: Fix shiftlag and implement HotkeyDown event, change HotkeyPress event to be non-repeating.

refs: #4915

Harbormaster completed building B11836: rP23701: Implement keyDown event .May 27 2020, 12:00 AM

Silier awarded a token.May 27 2020, 8:35 AM

wraitii mentioned this in D1703: Map browser for gamesetup.Jun 6 2020, 2:49 PM

KeyDown event still keeps being called after being pressed down.
Example: add a warn inside stopUnits functions and see how it repeats.

This commit now has outstanding concerns.Mar 26 2021, 12:59 PM

That is a feature not a bug. Keydown should repeat, keyPress should fire just once. StopUnits has been explicitly discussed to be keyDown (hence repeating), (One reason being ungarrison, another being units going the attack)

This commit now requires verification by auditors.Mar 26 2021, 1:08 PM

In rP23701#50076, @bb wrote:

That is a feature not a bug. Keydown should repeat, keyPress should fire just once. StopUnits has been explicitly discussed to be keyDown (hence repeating), (One reason being ungarrison, another being units going the attack)

Okey thanks, was testing and monitoring key events that are sent to the gui and got confused.

All concerns with this commit have now been addressed.Mar 26 2021, 1:11 PM