Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP23774

Move LOS to a los helper header and cleanup Grid.h includes.
AuditedrP23774
Actions

Description

Move LOS to a los helper header and cleanup Grid.h includes.

Changing Grid.h should recompile faster, as it is now included in fewer TUs.

Differential Revision: https://code.wildfiregames.com/D2784

Details

Auditors

Itms

Committed

wraitii

Jun 14 2020, 10:39 PM

Differential Revision

D2784: Move LOS to a los helper header and cleanup Grid.h includes

Parents

rP23773: Don't overwrite JS error reporting by calling JS_ReportError.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 12112
Build 22825: Trigger Windows Autobuild
Build 22824: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP23774: Move LOS to a los helper header and cleanup Grid.h includes..Jun 14 2020, 10:39 PM

wraitii added an edge: D2784: Move LOS to a los helper header and cleanup Grid.h includes.

Harbormaster completed building B12112: rP23774: Move LOS to a los helper header and cleanup Grid.h includes..Jun 14 2020, 11:14 PM

The two new files should have the svn:eol-style property set to native like all other source files ??

This commit now has outstanding concerns.Jun 22 2020, 8:16 PM

wraitii mentioned this in rP23827: Fix eol-style:native on files added in rP23774.Jul 14 2020, 9:31 AM

wraitii requested verification of this commit.Jul 14 2020, 9:59 AM

This commit now requires verification by auditors.Jul 14 2020, 9:59 AM

Itms accepted this commit.Jul 14 2020, 10:10 AM

All concerns with this commit have now been addressed.Jul 14 2020, 10:10 AM

Changes (23)

Path

Size

ps/

trunk/

source/

graphics/

CameraController.cpp

LOSTexture.cpp

LOSTexture.h

TerritoryBoundary.cpp

TerritoryTexture.cpp

tests/

test_LOSTexture.h

gui/

ObjectTypes/

CMiniMap.cpp

simulation2/

components/

CCmpObstructionManager.cpp

CCmpPathfinder_Common.h

CCmpProjectileManager.cpp

CCmpRallyPointRenderer.cpp

CCmpRallyPointRenderer.h

CCmpRangeManager.cpp

ICmpObstructionManager.h

ICmpRangeManager.h

tests/

test_HierPathfinder.h

test_Pathfinder.h

helpers/

HierarchicalPathfinder.cpp

rP23774

View Options

ps/trunk/source/graphics/CameraController.cpp

View Options

ps/trunk/source/graphics/LOSTexture.cpp

View Options

ps/trunk/source/graphics/LOSTexture.h

View Options

ps/trunk/source/graphics/TerritoryBoundary.cpp

View Options

ps/trunk/source/graphics/TerritoryTexture.cpp

View Options

ps/trunk/source/graphics/tests/test_LOSTexture.h

View Options

ps/trunk/source/gui/ObjectTypes/CMiniMap.cpp

View Options

ps/trunk/source/simulation2/components/CCmpObstructionManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpPathfinder_Common.h

View Options

ps/trunk/source/simulation2/components/CCmpProjectileManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpRallyPointRenderer.cpp

View Options

ps/trunk/source/simulation2/components/CCmpRallyPointRenderer.h

View Options

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

View Options

ps/trunk/source/simulation2/components/ICmpObstructionManager.h

View Options

ps/trunk/source/simulation2/components/ICmpRangeManager.h

View Options

ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h

View Options

ps/trunk/source/simulation2/components/tests/test_Pathfinder.h

View Options

ps/trunk/source/simulation2/helpers/HierarchicalPathfinder.cpp

View Options

ps/trunk/source/simulation2/helpers/LongPathfinder.h

View Options

ps/trunk/source/simulation2/helpers/Los.h

View Options

ps/trunk/source/simulation2/helpers/Pathfinding.cpp

View Options

ps/trunk/source/simulation2/helpers/Pathfinding.h

View Options

ps/trunk/source/simulation2/helpers/VertexPathfinder.cpp

Move LOS to a los helper header and cleanup Grid.h includes.AuditedrP23774Actions

Description

Details

Event Timeline

Changes (23)

rP23774

ps/trunk/source/graphics/CameraController.cpp

ps/trunk/source/graphics/LOSTexture.cpp

ps/trunk/source/graphics/LOSTexture.h

ps/trunk/source/graphics/TerritoryBoundary.cpp

ps/trunk/source/graphics/TerritoryTexture.cpp

ps/trunk/source/graphics/tests/test_LOSTexture.h

ps/trunk/source/gui/ObjectTypes/CMiniMap.cpp

ps/trunk/source/simulation2/components/CCmpObstructionManager.cpp

ps/trunk/source/simulation2/components/CCmpPathfinder_Common.h

ps/trunk/source/simulation2/components/CCmpProjectileManager.cpp

ps/trunk/source/simulation2/components/CCmpRallyPointRenderer.cpp

ps/trunk/source/simulation2/components/CCmpRallyPointRenderer.h

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

ps/trunk/source/simulation2/components/ICmpObstructionManager.h

ps/trunk/source/simulation2/components/ICmpRangeManager.h

ps/trunk/source/simulation2/components/tests/test_HierPathfinder.h

ps/trunk/source/simulation2/components/tests/test_Pathfinder.h

ps/trunk/source/simulation2/helpers/HierarchicalPathfinder.cpp

ps/trunk/source/simulation2/helpers/LongPathfinder.h

ps/trunk/source/simulation2/helpers/Los.h

ps/trunk/source/simulation2/helpers/Pathfinding.cpp

ps/trunk/source/simulation2/helpers/Pathfinding.h

ps/trunk/source/simulation2/helpers/VertexPathfinder.cpp

Move LOS to a los helper header and cleanup Grid.h includes.
AuditedrP23774
Actions