HomeWildfire Games
Diffusion 0 A.D. Public Repository rP23804

[gameplay-a24] differentiate African and Indian war elephants because of their…
rP23804
Actions

Description

[gameplay-a24] differentiate African and Indian war elephants because of their sizes.

maur, pers, sele champion elephants +10% resource costs, training time, health, and attack damage;
cart, kush, ptol champion elephants −10% resource costs, training time, health, and attack damage.

Patch by: @Nescio
Accepted by: @Feldfeld, @borg-

Differential Revision: https://code.wildfiregames.com/D2861

Details

Committed
StanJul 4 2020, 8:15 PM
Differential Revision
D2861: [gameplay] differentiate African and Indian war elephants
Parents
rP23803: Deprecate rotary mill, and instead introduce a special technology (town phase…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 12305
Build 23380: Post-Commit BuildJenkins
Build 23379: Post-Commit Build (macOS)Jenkins

Event Timeline

Stan committed rP23804: [gameplay-a24] differentiate African and Indian war elephants because of their….Jul 4 2020, 8:15 PM
Stan added an edge: D2861: [gameplay] differentiate African and Indian war elephants.
Stan added subscribers: Nescio, Feldfeld, borg-.
Harbormaster completed building B12305: rP23804: [gameplay-a24] differentiate African and Indian war elephants because of their….Jul 4 2020, 8:19 PM
Nescio mentioned this in D2862: [gameplay] introduce maur elephant civ bonus..Jul 4 2020, 8:56 PM
minohaka raised a concern with this commit.Jul 5 2020, 8:23 PM
minohaka added a subscriber: minohaka.

Was playing the Mauryas an got these (interestinglog.html):

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/maur_champion_elephant:1: Element Resources failed to validate content

ERROR: RelaxNGValidator: Validation error: (null):0: Extra element food in interleave

ERROR: RelaxNGValidator: Validation error: units/maur_champion_elephant:1: Element Loot failed to validate content

ERROR: RelaxNGValidator: Validation failed for '(null)'

ERROR: Failed to validate entity template 'units/maur_champion_elephant'

ERROR: JavaScript error: gui/session/session.js line 222 Error: deepfreeze requires exactly one object as an argument. GetTemplateData@gui/session/session.js:222:1 g_SelectionPanels.Training.setupButton@gui/session/selection_panels.js:933:18 setupUnitPanel@gui/session/unit_commands.js:95:8 updateUnitCommands@gui/session/unit_commands.js:147:4 updateSelectionDetails@gui/session/selection_details.js:499:2 updateGUIObjects@gui/session/session.js:663:2 onTick@gui/session/session.js:598:3 __eventhandler50 (Tick)@session Tick:0:1

ERROR: Errors executing script event "Tick"

ERROR: JavaScript error: gui/session/session.js line 222 Error: deepfreeze requires exactly one object as an argument. GetTemplateData@gui/session/session.js:222:1 g_SelectionPanels.Training.setupButton@gui/session/selection_panels.js:933:18 setupUnitPanel@gui/session/unit_commands.js:95:8 updateUnitCommands@gui/session/unit_commands.js:147:4 updateSelectionDetails@gui/session/selection_details.js:499:2 updateGUIObjects@gui/session/session.js:663:2 onSimulationUpdate@gui/session/session.js:634:2 __eventhandler52 (SimulationUpdate)@session SimulationUpdate:0:1

ERROR: Errors executing script event "SimulationUpdate"
This commit now has outstanding concerns.Jul 5 2020, 8:23 PM
Stan added a comment.Jul 5 2020, 8:27 PM

Thanks for the report!

Stan added a comment.Jul 5 2020, 8:42 PM

Looks like I need mul_round instead of mul

Stan mentioned this in rP23810: Fix broken templates following rP23804 while retaining the same functionnality.Jul 8 2020, 1:21 PM
Stan requested verification of this commit.Jul 9 2020, 11:24 AM
This commit now requires verification by auditors.Jul 9 2020, 11:24 AM
Stan removed an auditor: minohaka.Dec 5 2020, 5:26 PM
This commit no longer requires audit.Dec 5 2020, 5:26 PM

Changes (8)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
templates/
units/

rP23804

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_champion_elephant_melee_african.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_champion_elephant_melee_indian.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/cart_champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/kush_champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/maur_champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/pers_champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/ptol_champion_elephant.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/units/sele_champion_elephant.xml

Loading...
Wildfire Games · Phabricator