HomeWildfire Games

Improve ship pickup.


Improve ship pickup.

Improve unitAI: don't move if the requester can reach us and we are close enough. This avoids an issue where ships moved more than necessary when picking up many units.
Also improve requester UnitAI -> retry pickup if the target entity is Idle.
Improve unitMotion: periodically recompute paths in "known bad path" mode to adapt to moving targets.
Expose UnitMotion reachability to scripts and other code.

This adds a test map for some common and some tricky pickup cases, using triggers.

Based on a patch by: causative

Reviewed By: Freagarach

Fixes #3472

Differential Revision: https://code.wildfiregames.com/D665

Event Timeline

bb raised a concern with this commit.Sep 4 2020, 11:21 PM
bb added a subscriber: bb.

For some reason formation movement is broken after this commit: formationmembers get stuck at obstruction when colliding with them on a path. Reproducible by ordering a (large enough) formation to walk to the other side of a tree (or any obstruction really).

This commit now has outstanding concerns.Sep 4 2020, 11:21 PM
Silier raised a concern with this commit.Sep 6 2020, 12:38 PM
Silier added a subscriber: Silier.

Form formation at the start, it will never-ever move.
Formation controller is blocked by cc obstruction while stucked in it.

Hm, these reports are odd indeed, I'll investigate.

@Angen can you confirm that this diff changes something? Your problem sounds just like #4935

I did build of rP23924 and then rP23925. It was not present before this commit.

bb accepted this commit.Sep 8 2020, 3:50 PM
Silier accepted this commit.Sep 8 2020, 7:29 PM
All concerns with this commit have now been addressed.Sep 8 2020, 7:29 PM