HomeWildfire Games

Add num pad hotkey equivalents.

Description

Add num pad hotkey equivalents.

Such that now e.g. control groups can be selected using those.

Patch by: @Nescio
Differential Revision: D3029
Accepted by: @wraitii

Event Timeline

vladislavbelov added inline comments.
/ps/trunk/binaries/data/config/default.cfg
241

Quote myself:

We have to avoid that kind of alignment. It breaks SVN history for useless (imo) alignment.

Freagarach added inline comments.Nov 8 2020, 7:47 AM
/ps/trunk/binaries/data/config/default.cfg
241

Quoting myself:
Agreed.

Quoting CC:

Primarily, try to match the style of the functions that you're editing (assuming it's at least self-consistent and not too bizarre), in order to avoid making it less self-consistent.
Secondly, try to match the style of the files that you're editing.

Meaning one commit to change the whole file would fix this (and breaks SVN history also).

vladislavbelov added inline comments.Nov 8 2020, 8:36 AM
/ps/trunk/binaries/data/config/default.cfg
241

These rules are for usual cases. When we have intention to improve something, we might do it incrementally (like replacing NULL by nullptr when we touch related place).

Freagarach added inline comments.Nov 8 2020, 8:47 AM
/ps/trunk/binaries/data/config/default.cfg
241

Okay, thanks :) I'll keep this in mind for any next touch and sorry for now!