Diffusion 0 A.D. Public Repository rP24139

Always update preview in biome and landscape
rP24139
Actions

Description

Always update preview in biome and landscape

Introduced in rP23392.
Landscape and Biome previews are not updated correctly when reopeneing gamesetup.
To solve that, remove lastBiome and lastLandscape and always try to update preview if preview file exists and does not match with current one.

Differential revision: D3041
Reviewed by: @Freagarach
Fixes: #5785

Details

Committed

Silier

Nov 7 2020, 4:26 PM

Reviewer

Freagarach

Differential Revision

D3041: Always update preview in biome and landscape

Parents

rP24138: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 13495
Build 27310: Post-Commit Build	Jenkins
Build 27309: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP24139: Always update preview in biome and landscape.Nov 7 2020, 4:26 PM

Silier added an edge: D3041: Always update preview in biome and landscape.

Silier added a subscriber: Freagarach.

Harbormaster completed building B13495: rP24139: Always update preview in biome and landscape.Nov 7 2020, 4:34 PM

In gamesetup, load mainland notice preview is green, set biome to desert, notice it's desert, set it back to random, notice it's still desert. Not raising a concern as I'm not sure it's from this patch.

it is using random as biome so we should have mainland_random preview file, and because we do not have, it keeps one currently set and when opening first time, it keeps default one

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

gamesetup/

Pages/

GameSetupPage/

GameSettings/

Single/

Dropdowns/

Biome.js

Landscape.js

rP24139

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Pages/GameSetupPage/GameSettings/Single/Dropdowns/Biome.js