Diffusion 0 A.D. Public Repository rP24148

Move the controllability of an entity to cmpIdentity.
rP24148
Actions

Description

Move the controllability of an entity to cmpIdentity.

Where controllability is defined as the ability to receive _any_ order from the player.
Fixes the concern not raised at rP22446#42637.

Differential Revision: D1960
Reviewed By: @wraitii
Comments by: @bb, @Stan.

Details

Committed

Freagarach

Nov 9 2020, 9:38 AM

Reviewer

wraitii

Differential Revision

D1960: Move the controllability of an entity to cmpIdentity.

Parents

rP24147: Fix tower classes in maps.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 13525
Build 27414: Post-Commit Build	Jenkins
Build 27413: Post-Commit Build (macOS)	Jenkins

Event Timeline

Freagarach committed rP24148: Move the controllability of an entity to cmpIdentity..Nov 9 2020, 9:38 AM

Freagarach added an edge: D1960: Move the controllability of an entity to cmpIdentity..

Freagarach added subscribers: bb, Stan, wraitii.

Harbormaster completed building B13525: rP24148: Move the controllability of an entity to cmpIdentity..Nov 9 2020, 10:54 AM

Stan added inline comments.Nov 9 2020, 12:01 PM

/ps/trunk/binaries/data/mods/public/simulation/components/Identity.js
196	Can be affected by tech/auras after D3069
199	Currently unused?

wraitii added inline comments.Nov 9 2020, 12:03 PM

/ps/trunk/binaries/data/mods/public/simulation/components/Identity.js
199	Meant for scenarios, via triggers, such as D2771

wraitii mentioned this in D2771: Remove "domestic" attribute for wolves on polar sea.Nov 9 2020, 12:04 PM

Freagarach mentioned this in rP24359: Remove domestic attribute from wolves on polar sea..Dec 10 2020, 9:34 AM

Silier mentioned this in D4254: Added translatability of message "%(unit)s can't be controlled.".Sep 5 2021, 9:19 AM

Silier mentioned this in rP25916: Fix translation of "%(unit)s can't be controlled'.Sep 11 2021, 11:24 AM

Changes (7)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

unit_actions.js

unit_commands.js

simulation/

components/

tests/

helpers/

rP24148

View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/unit_commands.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Identity.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_GuiInterface.js

View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Commands.js

Move the controllability of an entity to cmpIdentity.rP24148Actions

Description

Details

Event Timeline

Changes (7)

rP24148

ps/trunk/binaries/data/mods/public/gui/session/unit_actions.js

ps/trunk/binaries/data/mods/public/gui/session/unit_commands.js

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

ps/trunk/binaries/data/mods/public/simulation/components/Identity.js

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_GuiInterface.js

ps/trunk/binaries/data/mods/public/simulation/helpers/Commands.js

Move the controllability of an entity to cmpIdentity.
rP24148
Actions