HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24171

Encapsulate runtime creation.
rP24171
Actions

Description

Encapsulate runtime creation.

  • Makes it easier to change down the line (and change is coming)
  • Allows making g_ScriptRuntime thread-local easily.
  • Remove ParentRuntime, which is not used at the moment.

Part of the SM52 migration, stage: SM45 compatible.

Patch by: Itms

Tested By: Freagarach

Refs #4893

Differential Revision: https://code.wildfiregames.com/D3087

Details

Committed
wraitiiNov 12 2020, 10:34 AM
Differential Revision
D3087: Encapsulate runtime creation.
Parents
rP24170: Remove DefPersistentRooted and unneeded includes.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 13599
Build 27670: Trigger Windows Autobuild
Build 27669: Post-Commit BuildJenkins
Build 27668: Post-Commit Build (macOS)Jenkins

Event Timeline

wraitii committed rP24171: Encapsulate runtime creation..Nov 12 2020, 10:34 AM
wraitii added an edge: D3087: Encapsulate runtime creation..
Harbormaster failed to build B13599: rP24171: Encapsulate runtime creation.!Nov 12 2020, 10:46 AM
vladislavbelov added a subscriber: vladislavbelov.Nov 13 2020, 3:15 PM
vladislavbelov added inline comments.
/ps/trunk/source/ps/GameSetup/GameSetup.cpp
112

Why it should be shared_ptr if it's thread_local?

/ps/trunk/source/scriptinterface/ScriptInterface.h
57

Sounds like a workaround, should be fixed.

/ps/trunk/source/scriptinterface/ScriptRuntime.cpp
94

That's the unsafe creation of std::shared_ptr, should be std::make_shared instead.

wraitii added inline comments.Nov 13 2020, 3:17 PM
/ps/trunk/source/ps/GameSetup/GameSetup.cpp
112

As you write below, this is more or less a workaround. I plan to fix it downstream.

Changes (10)

PathSize
ps/
trunk/
source/
graphics/
network/
ps/
GameSetup/
scriptinterface/

rP24171

View Options

ps/trunk/source/graphics/MapGenerator.cpp

Loading...
View Options

ps/trunk/source/network/NetServer.cpp

Loading...
View Options

ps/trunk/source/ps/GameSetup/GameSetup.cpp

Loading...
View Options

ps/trunk/source/ps/Replay.cpp

Loading...
View Options

ps/trunk/source/scriptinterface/NativeWrapperDefns.h

Loading...
View Options

ps/trunk/source/scriptinterface/ScriptInterface.cpp

Loading...
View Options

ps/trunk/source/scriptinterface/ScriptInterface.h

Loading...
View Options

ps/trunk/source/scriptinterface/ScriptRuntime.cpp

Loading...
View Options

ps/trunk/source/scriptinterface/ScriptRuntime.h

Loading...
View Options

ps/trunk/source/test_setup.cpp

Loading...
Wildfire Games ยท Phabricator