Diffusion 0 A.D. Public Repository rP24180

Explicitly make ScriptInterface a Compartment wrapper.
rP24180
Actions

Description

Explicitly make ScriptInterface a Compartment wrapper.

ScriptInterface is now a wrapper around a JSCompartment, and thus always has a well-defined global.

The error reporter is moved to ScriptRuntime in anticipation of that handling JSContext in a later diff.

Part of the SM52 migration, stage: SM45 compatible.

Patch by: Itms

Tested By: Freagarach

Refs #4893

Differential Revision: https://code.wildfiregames.com/D3090

Details

Committed

wraitii

Nov 14 2020, 9:46 AM

Differential Revision

D3101: Fix JS OOM in tests following rP24180

Parents

rP24179: [Windows] Automated build.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 13627
Build 27770: Trigger Windows Autobuild
Build 27769: Post-Commit Build	Jenkins
Build 27768: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP24180: Explicitly make ScriptInterface a Compartment wrapper..Nov 14 2020, 9:46 AM

wraitii added an edge: D3090: Promote compartments in ScriptInterface.

Harbormaster failed to build B13627: rP24180: Explicitly make ScriptInterface a Compartment wrapper.!Nov 14 2020, 10:00 AM

wraitii mentioned this in D3101: Fix JS OOM in tests following rP24180.Nov 14 2020, 3:41 PM

wraitii added an edge: D3101: Fix JS OOM in tests following rP24180.Nov 14 2020, 4:12 PM

wraitii mentioned this in rP24182: Fix JS OOM in tests following rP24180.Nov 14 2020, 4:14 PM

wraitii mentioned this in rP24297: [SM68 2/2] Update to Spidermonkey 68 APIs.Nov 30 2020, 10:04 AM

Changes (24)

Path

Size

ps/

trunk/

source/

graphics/

gui/

ObjectBases/

tests/

lobby/

network/

scripting/

JSInterface_Network.cpp

ps/

GameSetup/

scripting/

JSInterface_SavedGame.cpp

scriptinterface/

tests/

test_ScriptConversions.h

test_ScriptInterface.h

simulation2/

Simulation2.cpp

components/

CCmpAIManager.cpp

CCmpCommandQueue.cpp

scripting/

EngineScriptConversions.cpp

JSInterface_Simulation.cpp

rP24180

View Options

ps/trunk/source/graphics/MapGenerator.cpp

View Options

ps/trunk/source/gui/CGUI.cpp

View Options

ps/trunk/source/gui/CGUI.h

View Options

ps/trunk/source/gui/GUIManager.cpp

View Options

ps/trunk/source/gui/ObjectBases/IGUIObject.cpp

View Options

ps/trunk/source/gui/tests/test_GuiManager.h

View Options

ps/trunk/source/lobby/XmppClient.cpp

View Options

ps/trunk/source/network/scripting/JSInterface_Network.cpp

View Options

ps/trunk/source/ps/Game.cpp

View Options

ps/trunk/source/ps/GameSetup/GameSetup.cpp

View Options

ps/trunk/source/ps/GameSetup/HWDetect.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_Game.cpp

View Options

ps/trunk/source/ps/scripting/JSInterface_SavedGame.cpp

View Options

ps/trunk/source/scriptinterface/ScriptInterface.cpp

View Options

ps/trunk/source/scriptinterface/ScriptInterface.h

View Options

ps/trunk/source/scriptinterface/ScriptRuntime.cpp

View Options

ps/trunk/source/scriptinterface/ScriptRuntime.h

View Options

ps/trunk/source/scriptinterface/tests/test_ScriptConversions.h

View Options

ps/trunk/source/scriptinterface/tests/test_ScriptInterface.h

View Options

ps/trunk/source/simulation2/Simulation2.cpp

View Options

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpCommandQueue.cpp

View Options

ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp

View Options

ps/trunk/source/simulation2/scripting/JSInterface_Simulation.cpp

Explicitly make ScriptInterface a Compartment wrapper.rP24180Actions

Description

Details

Event Timeline

Changes (24)

rP24180

ps/trunk/source/graphics/MapGenerator.cpp

ps/trunk/source/gui/CGUI.cpp

ps/trunk/source/gui/CGUI.h

ps/trunk/source/gui/GUIManager.cpp

ps/trunk/source/gui/ObjectBases/IGUIObject.cpp

ps/trunk/source/gui/tests/test_GuiManager.h

ps/trunk/source/lobby/XmppClient.cpp

ps/trunk/source/network/scripting/JSInterface_Network.cpp

ps/trunk/source/ps/Game.cpp

ps/trunk/source/ps/GameSetup/GameSetup.cpp

ps/trunk/source/ps/GameSetup/HWDetect.cpp

ps/trunk/source/ps/scripting/JSInterface_Game.cpp

ps/trunk/source/ps/scripting/JSInterface_SavedGame.cpp

ps/trunk/source/scriptinterface/ScriptInterface.cpp

ps/trunk/source/scriptinterface/ScriptInterface.h

ps/trunk/source/scriptinterface/ScriptRuntime.cpp

ps/trunk/source/scriptinterface/ScriptRuntime.h

ps/trunk/source/scriptinterface/tests/test_ScriptConversions.h

ps/trunk/source/scriptinterface/tests/test_ScriptInterface.h

ps/trunk/source/simulation2/Simulation2.cpp

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

ps/trunk/source/simulation2/components/CCmpCommandQueue.cpp

ps/trunk/source/simulation2/scripting/EngineScriptConversions.cpp

ps/trunk/source/simulation2/scripting/JSInterface_Simulation.cpp

Explicitly make ScriptInterface a Compartment wrapper.
rP24180
Actions