HomeWildfire Games

Allow registering hooks that trigger on config changes.

Description

Allow registering hooks that trigger on config changes.

Rendering options use this capability to simplify their implementation. This makes it easier to add new options.

Comments by: vladislavbelov

Differential Revision: https://code.wildfiregames.com/D2293

Event Timeline

vladislavbelov added inline comments.
/ps/trunk/source/renderer/RenderingOptions.h
116โ€“126

You don't need these functions in the interface, there're useless here. Since their bodies are the only proxies.

wraitii added inline comments.Sat, Nov 21, 5:39 PM
/ps/trunk/source/renderer/RenderingOptions.h
116โ€“126

I recall I had problem with private access if they weren't here.

vladislavbelov added inline comments.Sun, Nov 22, 1:04 AM
/ps/trunk/source/renderer/RenderingOptions.h
116โ€“126

Why are you trying to access a private member? Just pass the member as a reference or make the setup function a method of the implementation class.