HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24228

Allow registering hooks that trigger on config changes.
rP24228
Actions

Description

Allow registering hooks that trigger on config changes.

Rendering options use this capability to simplify their implementation. This makes it easier to add new options.

Comments by: vladislavbelov

Differential Revision: https://code.wildfiregames.com/D2293

Details

Auditors
vladislavbelov
Committed
wraitiiNov 21 2020, 12:57 PM
Differential Revision
D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further.
Parents
rP24227: Clean up header includes, add new forward declarations.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 13854
Build 28585: Trigger Windows Autobuild
Build 28584: Post-Commit BuildJenkins
Build 28583: Post-Commit Build (macOS)Jenkins

Event Timeline

wraitii committed rP24228: Allow registering hooks that trigger on config changes..Nov 21 2020, 12:57 PM
wraitii added an edge: D2293: Allow code to register hooks which get called whenever a function value changes, use this to clean rendering options further..
Harbormaster failed to build B13854: rP24228: Allow registering hooks that trigger on config changes.!Nov 21 2020, 2:17 PM
vladislavbelov added a subscriber: vladislavbelov.Nov 21 2020, 5:38 PM
vladislavbelov added inline comments.
/ps/trunk/source/renderer/RenderingOptions.h
116–126

You don't need these functions in the interface, there're useless here. Since their bodies are the only proxies.

wraitii added inline comments.Nov 21 2020, 5:39 PM
/ps/trunk/source/renderer/RenderingOptions.h
116–126

I recall I had problem with private access if they weren't here.

wraitii mentioned this in D3131: Fix assertion failure in rP24228 caused by a race condition..Nov 21 2020, 5:58 PM
vladislavbelov added inline comments.Nov 22 2020, 1:04 AM
/ps/trunk/source/renderer/RenderingOptions.h
116–126

Why are you trying to access a private member? Just pass the member as a reference or make the setup function a method of the implementation class.

wraitii mentioned this in rP24233: Fix rendering options failures following rP24228.Nov 22 2020, 12:09 PM
vladislavbelov raised a concern with this commit.Jan 12 2021, 8:48 PM
vladislavbelov added inline comments.
/ps/trunk/source/renderer/RenderingOptions.cpp
166

Followed the wrong code in rP17737 and broke the option.

This commit now has outstanding concerns.Jan 12 2021, 8:48 PM
wraitii mentioned this in D3348: Fix shadows-on-water option..Jan 13 2021, 9:35 AM
wraitii requested verification of this commit.Jan 13 2021, 11:04 AM
This commit now requires verification by auditors.Jan 13 2021, 11:04 AM
wraitii mentioned this in rP24593: Fix shadows-on-water option..Jan 13 2021, 11:04 AM
vladislavbelov resigned from this commit.Jan 13 2021, 1:27 PM
This commit no longer requires audit.Jan 13 2021, 1:27 PM

Changes (9)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
gui/
options/
session/
source/
ps/
renderer/
scripting/

rP24228

View Options

ps/trunk/binaries/data/mods/public/gui/options/options.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/session/session.js

Loading...
View Options

ps/trunk/source/ps/ConfigDB.cpp

Loading...
View Options

ps/trunk/source/ps/ConfigDB.h

Loading...
View Options

ps/trunk/source/renderer/Renderer.h

Loading...
View Options

ps/trunk/source/renderer/RenderingOptions.cpp

Loading...
View Options

ps/trunk/source/renderer/RenderingOptions.h

Loading...
View Options

ps/trunk/source/renderer/scripting/JSInterface_Renderer.cpp

Loading...
View Options

ps/trunk/source/renderer/scripting/JSInterface_Renderer.h

Loading...
Wildfire Games · Phabricator